From 140f59bef6eac455f3094c9ef782ff782f3831b2 Mon Sep 17 00:00:00 2001
From: Valentin Rigal <rigal@teklia.com>
Date: Wed, 3 Apr 2024 13:42:06 +0200
Subject: [PATCH] Suggestions
---
.../training/migrations/0008_dataset_unique_elements.py | 6 +++---
arkindex/training/serializers.py | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arkindex/training/migrations/0008_dataset_unique_elements.py b/arkindex/training/migrations/0008_dataset_unique_elements.py
index 44224cfde6..229afdda54 100644
--- a/arkindex/training/migrations/0008_dataset_unique_elements.py
+++ b/arkindex/training/migrations/0008_dataset_unique_elements.py
@@ -11,9 +11,9 @@ def update_unique_elements(apps, schema_editor):
models.Exists(
DatasetElement.objects
.filter(set__dataset_id=models.OuterRef("pk"))
- .values("element")
- .annotate(dups=models.Count("element"))
- .filter(dups__gte=2)
+ .values("element_id")
+ .annotate(dupes=models.Count("element_id"))
+ .filter(dupes__gte=2)
)
).update(unique_elements=False)
diff --git a/arkindex/training/serializers.py b/arkindex/training/serializers.py
index 9686bbb124..5faa79fc61 100644
--- a/arkindex/training/serializers.py
+++ b/arkindex/training/serializers.py
@@ -583,9 +583,9 @@ class DatasetSerializer(serializers.ModelSerializer):
if unique is True and self.instance and (
DatasetElement.objects
.filter(set__dataset_id=self.instance.pk)
- .values("element")
- .annotate(dups=Count("element"))
- .filter(dups__gte=2)
+ .values("element_id")
+ .annotate(dupes=Count("element_id"))
+ .filter(dupes__gte=2)
.exists()
):
raise ValidationError("Elements are currently contained by multiple sets.")
--
GitLab