From e190b61119ca294b5ecde12de654c8222bc92d77 Mon Sep 17 00:00:00 2001
From: Yoann Schneider <yschneider@teklia.com>
Date: Fri, 12 Apr 2024 19:01:54 +0200
Subject: [PATCH] Comply with RET504
---
arkindex/documents/serializers/elements.py | 3 +--
arkindex/documents/serializers/entities.py | 3 +--
arkindex/training/admin.py | 3 +--
ruff.toml | 2 ++
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/arkindex/documents/serializers/elements.py b/arkindex/documents/serializers/elements.py
index 7c70990226..d8ba836bed 100644
--- a/arkindex/documents/serializers/elements.py
+++ b/arkindex/documents/serializers/elements.py
@@ -667,8 +667,7 @@ class ElementSerializer(ElementTinySerializer):
validated_data.update(image=image, polygon=polygon)
- instance = super().update(instance, validated_data)
- return instance
+ return super().update(instance, validated_data)
class ElementNeighborsSerializer(serializers.ModelSerializer):
diff --git a/arkindex/documents/serializers/entities.py b/arkindex/documents/serializers/entities.py
index 1f107ee06b..335e63e450 100644
--- a/arkindex/documents/serializers/entities.py
+++ b/arkindex/documents/serializers/entities.py
@@ -32,8 +32,7 @@ class EntityTypeSerializer(serializers.ModelSerializer):
corpus = data.get("corpus")
if self.instance and corpus:
raise ValidationError({"corpus": ["It is not possible to update an Entity Type's corpus."]})
- data = super().to_internal_value(data)
- return data
+ return super().to_internal_value(data)
def validate(self, data):
name = data.get("name") if "name" in data else self.instance.name
diff --git a/arkindex/training/admin.py b/arkindex/training/admin.py
index f8cc278929..c3c6c7a8b5 100644
--- a/arkindex/training/admin.py
+++ b/arkindex/training/admin.py
@@ -48,8 +48,7 @@ class DatasetAdmin(admin.ModelAdmin):
self.readonly_fields = self.__class__.readonly_fields
if obj is not None:
self.readonly_fields += ("unique_elements",)
- form = super().get_form(request, obj=None, **kwargs)
- return form
+ return super().get_form(request, obj=None, **kwargs)
admin.site.register(Model, ModelAdmin)
diff --git a/ruff.toml b/ruff.toml
index 073e291f27..c32e4d8b50 100644
--- a/ruff.toml
+++ b/ruff.toml
@@ -10,5 +10,7 @@ select = ["Q0", "F", "W", "E",
"S113",
# flake8-return: unnecessary-return-none
"RET501",
+ # flake8-return: unnecessary-assign
+ "RET504",
]
ignore = ["E501"]
--
GitLab