From 42765c91fa0573df03ba83548657d99276da4e81 Mon Sep 17 00:00:00 2001
From: manonBlanco <blanco@teklia.com>
Date: Tue, 21 Nov 2023 12:23:19 +0100
Subject: [PATCH] Remove useless `validate_uuid` function
---
dan/datasets/extract/__init__.py | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/dan/datasets/extract/__init__.py b/dan/datasets/extract/__init__.py
index a7c83525..c2634de5 100644
--- a/dan/datasets/extract/__init__.py
+++ b/dan/datasets/extract/__init__.py
@@ -5,6 +5,7 @@ Extract dataset from Arkindex using a corpus export.
import argparse
import pathlib
+from typing import Union
from uuid import UUID
from dan.datasets.extract.arkindex import run
@@ -12,18 +13,15 @@ from dan.datasets.extract.arkindex import run
MANUAL_SOURCE = "manual"
-def validate_uuid(arg_uuid):
- try:
- return UUID(arg_uuid)
- except ValueError:
- raise argparse.ArgumentTypeError(f"`{arg_uuid}` is not a valid UUID.")
-
-
-def parse_worker_version(worker_version_id):
+def parse_worker_version(worker_version_id) -> Union[str, bool]:
if worker_version_id == MANUAL_SOURCE:
return False
- validate_uuid(worker_version_id)
+ try:
+ UUID(worker_version_id)
+ except ValueError:
+ raise argparse.ArgumentTypeError(f"`{worker_version_id}` is not a valid UUID.")
+
return worker_version_id
@@ -79,19 +77,19 @@ def add_extract_parser(subcommands) -> None:
parser.add_argument(
"--train-folder",
- type=validate_uuid,
+ type=UUID,
help="ID of the training folder to extract from Arkindex.",
required=True,
)
parser.add_argument(
"--val-folder",
- type=validate_uuid,
+ type=UUID,
help="ID of the validation folder to extract from Arkindex.",
required=True,
)
parser.add_argument(
"--test-folder",
- type=validate_uuid,
+ type=UUID,
help="ID of the testing folder to extract from Arkindex.",
required=True,
)
--
GitLab