From afbe821f2e7112741bfab342e978ac3ff9788791 Mon Sep 17 00:00:00 2001
From: Yoann Schneider <yschneider@teklia.com>
Date: Wed, 15 Nov 2023 15:57:52 +0100
Subject: [PATCH] Higher level on retry logs
---
dan/datasets/extract/utils.py | 2 +-
tests/test_extract.py | 8 +++++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/dan/datasets/extract/utils.py b/dan/datasets/extract/utils.py
index 6bd3693c..70903330 100644
--- a/dan/datasets/extract/utils.py
+++ b/dan/datasets/extract/utils.py
@@ -33,7 +33,7 @@ TRIM_RETURN_REGEX = re.compile(r"[\r\n]+")
def _retry_log(retry_state, *args, **kwargs):
- logger.debug(
+ logger.warning(
f"Request to {retry_state.args[0]} failed ({repr(retry_state.outcome.exception())}), "
f"retrying in {retry_state.idle_for} seconds"
)
diff --git a/tests/test_extract.py b/tests/test_extract.py
index ce4e1358..4240e2fb 100644
--- a/tests/test_extract.py
+++ b/tests/test_extract.py
@@ -741,7 +741,7 @@ def test_download_image_error(iiif_url, caplog, capsys):
assert captured.out == "deadbeef: Image URL must be HTTP(S)\n"
-def test_download_image_error_try_max(responses):
+def test_download_image_error_try_max(responses, caplog):
# An image's URL
url = (
"https://blabla.com/iiif/2/image_path.jpg/231,699,2789,3659/full/0/default.jpg"
@@ -774,6 +774,12 @@ def test_download_image_error_try_max(responses):
fixed_url
]
+ # Check error log
+ assert len(caplog.record_tuples) == 2
+
+ # We should only have WARNING levels
+ assert set(level for _, level, _ in caplog.record_tuples) == {logging.WARNING}
+
@pytest.mark.parametrize("allow_empty", (True, False))
def test_empty_transcription(allow_empty, mock_database):
--
GitLab