From 9b2c2752b1c5b56790c6d92625424b5b5db98b48 Mon Sep 17 00:00:00 2001
From: Valentin Rigal <rigal@teklia.com>
Date: Wed, 19 May 2021 11:46:08 +0200
Subject: [PATCH] Avoid updating activity to error when we could not fetch the
element
---
arkindex_worker/worker/__init__.py | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arkindex_worker/worker/__init__.py b/arkindex_worker/worker/__init__.py
index 77412c47..d83b92a1 100644
--- a/arkindex_worker/worker/__init__.py
+++ b/arkindex_worker/worker/__init__.py
@@ -151,11 +151,8 @@ class ElementsWorker(
self.update_activity(element.id, ActivityState.Processed)
except Exception as e:
failed += 1
- element_id = (
- element.id
- if isinstance(element, (Element, CachedElement))
- else item
- )
+ # Handle the case where we failed retrieving the element
+ element_id = element.id if element else item
if isinstance(e, ErrorResponse):
message = f"An API error occurred while processing element {element_id}: {e.title} - {e.content}"
@@ -166,7 +163,8 @@ class ElementsWorker(
message,
exc_info=e if self.args.verbose else None,
)
- self.update_activity(element_id, ActivityState.Error)
+ if element:
+ self.update_activity(element.id, ActivityState.Error)
self.report.error(element_id, e)
# Save report as local artifact
--
GitLab