From e5b1f2502c37e556b2a18258deb8fb77c7762f41 Mon Sep 17 00:00:00 2001
From: Eva Bardou <ebardou@teklia.com>
Date: Mon, 26 Apr 2021 10:27:13 +0200
Subject: [PATCH] Fix a review related code snippet
---
arkindex_worker/worker/entity.py | 4 +++-
tests/test_elements_worker/test_entities.py | 3 +--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arkindex_worker/worker/entity.py b/arkindex_worker/worker/entity.py
index e42036e1..30c1637d 100644
--- a/arkindex_worker/worker/entity.py
+++ b/arkindex_worker/worker/entity.py
@@ -18,7 +18,9 @@ class EntityType(Enum):
class EntityMixin(object):
- def create_entity(self, element, name, type, corpus, metas=None, validated=None):
+ def create_entity(
+ self, element, name, type, corpus=None, metas=None, validated=None
+ ):
"""
Create an entity on the given corpus through API
Return the ID of the created entity
diff --git a/tests/test_elements_worker/test_entities.py b/tests/test_elements_worker/test_entities.py
index 540635de..1fe38b36 100644
--- a/tests/test_elements_worker/test_entities.py
+++ b/tests/test_elements_worker/test_entities.py
@@ -90,14 +90,13 @@ def test_create_entity_wrong_type(mock_elements_worker):
def test_create_entity_wrong_corpus(monkeypatch, mock_elements_worker):
elt = Element({"id": "12341234-1234-1234-1234-123412341234"})
- # Triggering an error on metas param, giving corpus=None should work since
+ # Triggering an error on metas param, not giving corpus should work since
# ARKINDEX_CORPUS_ID environment variable is set on mock_elements_worker
with pytest.raises(AssertionError) as e:
mock_elements_worker.create_entity(
element=elt,
name="Bob Bob",
type=EntityType.Person,
- corpus=None,
metas="wrong metas",
)
assert str(e.value) == "metas should be of type dict"
--
GitLab