diff --git a/arkindex_worker/worker/metadata.py b/arkindex_worker/worker/metadata.py index 74866797198ee153187d3024533218fe6094570f..990f6e904768deab115d4d7f749deffec1bdff74 100644 --- a/arkindex_worker/worker/metadata.py +++ b/arkindex_worker/worker/metadata.py @@ -109,7 +109,6 @@ class MetaDataMixin(object): self, element: Element, metadata_list: list, - worker_version: str = None, ): """ Create multiple metadatas on an existing element. @@ -157,7 +156,7 @@ class MetaDataMixin(object): "CreateMetaDataBulk", id=element.id, body={ - "worker_version": worker_version, + "worker_version": self.worker_version_id, "worker_run_id": self.worker_run_id, "metadata_list": metadata_list, }, diff --git a/tests/test_elements_worker/test_metadata.py b/tests/test_elements_worker/test_metadata.py index f56e684b8485db9d4fde372aac59b424851060f5..fb45f968ac484fd56680192ae0eeae6b7eccc4f3 100644 --- a/tests/test_elements_worker/test_metadata.py +++ b/tests/test_elements_worker/test_metadata.py @@ -199,40 +199,30 @@ def test_create_metadata(responses, mock_elements_worker): @pytest.mark.parametrize( - "worker_version, metadatas", + "metadatas", [ - (None, [MetaType("text"), "fake_name", "fake_value"]), - (None, [MetaType("text"), "fake_name", "fake_value", "fake_entity_id"]), - (None, [MetaType("text"), "fake_name", "fake_value", None]), - (None, [MetaType("text"), "fake_name", 13.5, None]), - (None, [MetaType("text"), "fake_name", 13.5, "fake_entity_id"]), - ("worker_version", [MetaType("text"), "fake_name", "fake_value"]), - ( - "worker_version", - [MetaType("text"), "fake_name", "fake_value", "fake_entity_id"], - ), - ("worker_version", [MetaType("text"), "fake_name", "fake_value", None]), - ("worker_version", [MetaType("text"), "fake_name", 13.5, None]), - ("worker_version", [MetaType("text"), "fake_name", 13.5, "fake_entity_id"]), + ([MetaType("text"), "fake_name", "fake_value"]), + ([MetaType("text"), "fake_name", "fake_value", "fake_entity_id"]), + ([MetaType("text"), "fake_name", "fake_value", None]), + ([MetaType("text"), "fake_name", 13.5, None]), + ([MetaType("text"), "fake_name", 13.5, "fake_entity_id"]), ], ) -def test_create_metadatas(fake_dummy_worker, worker_version, metadatas): +def test_create_metadatas(fake_dummy_worker, metadatas): element = Element({"id": "element_id"}) fake_dummy_worker.worker_run_id = "fake_worker_run_id" + fake_dummy_worker.worker_version_id = "fake_worker_version_id" fake_dummy_worker.api_client.add_response( "CreateMetaDataBulk", id=element.id, response={"metadata_list": metadatas}, body={ - "worker_version": worker_version, + "worker_version": fake_dummy_worker.worker_version_id, "worker_run_id": fake_dummy_worker.worker_run_id, "metadata_list": metadatas, }, ) - assert ( - fake_dummy_worker.create_metadatas(element, metadatas, worker_version) - == metadatas - ) + assert fake_dummy_worker.create_metadatas(element, metadatas) == metadatas assert len(fake_dummy_worker.api_client.history) == 1 assert len(fake_dummy_worker.api_client.responses) == 0