Skip to content
Snippets Groups Projects
Commit 3a421392 authored by ml bonhomme's avatar ml bonhomme :bee: Committed by Erwan Rouchet
Browse files

Do not validate use_gpu when none is being sent in the request

parent ca116dc2
No related branches found
No related tags found
1 merge request!2360Do not validate use_gpu when none is being sent in the request
......@@ -218,15 +218,13 @@ class WorkerRunEditSerializer(WorkerRunSerializer):
# Same as WorkerRunSerializer, but the worker_version_id cannot be edited
fields = tuple(set(WorkerRunSerializer.Meta.fields) - {"worker_version_id"})
def validate(self, data):
data = super().validate(data)
use_gpu = data.get("use_gpu", False)
def validate_use_gpu(self, use_gpu):
worker_version = self.instance.version
if worker_version.gpu_usage == FeatureUsage.Disabled and use_gpu:
raise ValidationError({"use_gpu": ["This worker version does not support GPU usage."]})
raise ValidationError("This worker version does not support GPU usage.")
if worker_version.gpu_usage == FeatureUsage.Required and not use_gpu:
raise ValidationError({"use_gpu": ["This worker version requires GPU usage."]})
return data
raise ValidationError("This worker version requires GPU usage.")
return use_gpu
class UserWorkerRunSerializer(serializers.ModelSerializer):
......
......@@ -174,7 +174,7 @@ class TestWorkerRunsGPU(FixtureAPITestCase):
parents=[]
)
self.assertEqual(run.use_gpu, True if worker_version.gpu_usage == FeatureUsage.Required else False)
with self.assertNumQueries(4):
with self.assertNumQueries(3):
response = self.client.patch(
reverse("api:worker-run-details", kwargs={"pk": str(run.id)}),
data={"use_gpu": use_gpu}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment