Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
Backend
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Container Registry
Analyze
Contributor analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Arkindex
Backend
Commits
d2f0800a
Commit
d2f0800a
authored
6 years ago
by
Erwan Rouchet
Browse files
Options
Downloads
Patches
Plain Diff
Remove filtering for admins
parent
da96424b
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
arkindex/dataimport/api.py
+17
-9
17 additions, 9 deletions
arkindex/dataimport/api.py
with
17 additions
and
9 deletions
arkindex/dataimport/api.py
+
17
−
9
View file @
d2f0800a
...
...
@@ -41,7 +41,8 @@ class DataImportsList(CorpusACLMixin, ListCreateAPIView):
if
serializer
.
validated_data
[
'
mode
'
]
not
in
(
DataImportMode
.
Images
,
):
raise
ValidationError
(
'
Unsupported mode for now, sorry.
'
)
if
Right
.
Write
not
in
serializer
.
validated_data
[
'
corpus
'
].
get_acl_rights
(
self
.
request
.
user
):
if
not
self
.
request
.
user
.
is_admin
and
\
Right
.
Write
not
in
serializer
.
validated_data
[
'
corpus
'
].
get_acl_rights
(
self
.
request
.
user
):
raise
PermissionDenied
return
super
().
perform_create
(
serializer
)
...
...
@@ -60,7 +61,8 @@ class DataImportDetails(RetrieveUpdateDestroyAPIView):
def
perform_update
(
self
,
serializer
):
dataimport
=
serializer
.
instance
if
Right
.
Write
not
in
dataimport
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
if
not
self
.
request
.
user
.
is_admin
and
\
Right
.
Write
not
in
dataimport
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
raise
PermissionDenied
if
dataimport
.
state
not
in
(
DataImportState
.
Created
,
DataImportState
.
Configured
):
...
...
@@ -84,7 +86,8 @@ class DataImportDetails(RetrieveUpdateDestroyAPIView):
dataimport
.
save
()
def
perform_destroy
(
self
,
instance
):
if
Right
.
Write
not
in
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
if
not
self
.
request
.
user
.
is_admin
and
\
Right
.
Write
not
in
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
raise
PermissionDenied
if
instance
.
state
==
DataImportState
.
Running
:
raise
ValidationError
(
"
Cannot delete a workflow while it is running
"
)
...
...
@@ -133,7 +136,7 @@ class DataImportDemo(CreateAPIView):
volume
=
get_object_or_404
(
Element
,
**
filters
)
assert
Right
.
Write
in
volume
.
corpus
.
get_acl_rights
(
self
.
request
.
user
),
\
assert
self
.
request
.
user
.
is_admin
or
Right
.
Write
in
volume
.
corpus
.
get_acl_rights
(
self
.
request
.
user
),
\
'
Corpus is not writable
'
# Start the import
...
...
@@ -175,12 +178,14 @@ class DataFileRetrieve(RetrieveUpdateDestroyAPIView):
return
DataFile
.
objects
.
filter
(
corpus__in
=
Corpus
.
objects
.
readable
(
self
.
request
.
user
))
def
perform_update
(
self
,
serializer
):
if
Right
.
Write
not
in
serializer
.
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
if
not
self
.
request
.
user
.
is_admin
and
\
Right
.
Write
not
in
serializer
.
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
raise
PermissionDenied
return
super
().
perform_update
(
serializer
)
def
perform_destroy
(
self
,
instance
):
if
Right
.
Write
not
in
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
if
not
self
.
request
.
user
.
is_admin
and
\
Right
.
Write
not
in
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
raise
PermissionDenied
return
super
().
perform_destroy
(
instance
)
...
...
@@ -201,7 +206,8 @@ class DataFileUpload(APIView):
corpus
=
corpus_qs
.
get
()
# Check corpus is writable for current user
if
Right
.
Write
not
in
corpus
.
get_acl_rights
(
self
.
request
.
user
):
if
not
self
.
request
.
user
.
is_admin
and
\
Right
.
Write
not
in
corpus
.
get_acl_rights
(
self
.
request
.
user
):
raise
PermissionDenied
file_obj
=
request
.
FILES
[
'
file
'
]
...
...
@@ -298,12 +304,14 @@ class RepositoryRetrieve(RetrieveUpdateDestroyAPIView):
)
def
perform_update
(
self
,
serializer
):
if
Right
.
Write
not
in
serializer
.
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
if
not
self
.
request
.
user
.
is_admin
and
\
Right
.
Write
not
in
serializer
.
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
raise
PermissionDenied
return
super
().
perform_update
(
self
,
serializer
)
def
perform_destroy
(
self
,
instance
):
if
Right
.
Write
not
in
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
if
not
self
.
request
.
user
.
is_admin
and
\
Right
.
Write
not
in
instance
.
corpus
.
get_acl_rights
(
self
.
request
.
user
):
raise
PermissionDenied
return
super
().
perform_destroy
(
self
,
instance
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment