Comply with RET503

arkindex/documents/date_parser.py

@@ -99,6 +99,7 @@ def year_month_str(raw_date):
             "month": months[0],
             "type": DateType.Exact
         }, )
+    return None
 
 
 def year_year(raw_date):

arkindex/documents/dates.py

@@ -68,6 +68,7 @@ class InterpretedDate(object):
             if s == o:
                 continue
             return s > o
+        return None
 
     def __str__(self):
         return "-".join("{:02d}".format(e) for e in tuple(self) if e)

arkindex/documents/serializers/elements.py

@@ -380,6 +380,7 @@ class ElementTinySerializer(serializers.ModelSerializer):
     def get_thumbnail_url(self, element):
         if element.type.folder:
             return element.thumbnail.s3_url
+        return None
 
     @extend_schema_field(CorpusLightSerializer(read_only=True))
     def get_corpus(self, element):
@@ -632,6 +633,7 @@ class ElementSerializer(ElementTinySerializer):
     def get_thumbnail_put_url(self, element):
         if element.type.folder and self.element_rights >= Role.Admin.value:
             return element.thumbnail.s3_put_url
+        return None
 
     def update(self, instance, validated_data):
         image = validated_data.pop("image", None)

arkindex/images/serializers.py

@@ -63,6 +63,7 @@ class ImageSerializer(serializers.ModelSerializer):
         # Only allow the S3 URL for admins or Ponos tasks
         if is_admin_or_ponos_task(self.context["request"]):
             return obj.s3_url
+        return None
 
     def validate_status(self, value):
         if not self.instance:

arkindex/ponos/utils.py

@@ -17,6 +17,7 @@ def is_admin_or_ponos_task(request):
 def get_process_from_task_auth(request):
     if isinstance(request.auth, Task):
         return request.auth.process
+    return None
 
 
 def upload_artifact(task, path, artifacts_dir):

arkindex/process/serializers/files.py

@@ -47,6 +47,8 @@ class DataFileSerializer(serializers.ModelSerializer):
             request_process = get_process_from_task_auth(request)
             if not request_process or request_process.mode in (ProcessMode.Files, ProcessMode.IIIF):
                 return obj.s3_url
+            return None
+        return None
 
 
 class DataFileCreateSerializer(serializers.ModelSerializer):

arkindex/project/admin.py

@@ -20,3 +20,4 @@ class ArchivedListFilter(admin.SimpleListFilter):
             return queryset.filter(archived__isnull=False)
         if self.value() == "false":
             return queryset.filter(archived__isnull=True)
+        return None

arkindex/project/fields.py

@@ -57,6 +57,7 @@ class ArrayField(fields.ArrayField):
             return transform
         if name == "last":
             return LastItemTransformFactory(self.base_field)
+        return None
 
 
 class Array(Func):

arkindex/project/tests/__init__.py

@@ -197,6 +197,7 @@ class FixtureMixin(object):
 
         with context:
             func(*args, **kwargs)
+            return None
 
 
 class FixtureTestCase(FixtureMixin, TestCase):

ruff.toml

@@ -10,5 +10,7 @@ select = ["Q0", "F", "W", "E",
     "RET501",
     # flake8-return: implicit-return-value
     "RET502",
+    # flake8-return: implicit-return
+    "RET503",
 ]
 ignore = ["E501"]