Skip to content
Snippets Groups Projects

Delete selected elements on a corpus

Merged Eva Bardou requested to merge delete-selected-elements into master
All threads resolved!

Refers #521 (closed)

Edited by Eva Bardou

Merge request reports

Checking pipeline status.

Approved by

Merged by Erwan RouchetErwan Rouchet 4 years ago (Dec 1, 2020 2:00pm UTC)

Merge details

  • Changes merged into master with 12948ce3 (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Erwan Rouchet
  • Eva Bardou added 8 commits

    added 8 commits

    Compare with previous version

  • Eva Bardou resolved all threads

    resolved all threads

  • Eva Bardou resolved all threads

    resolved all threads

  • Eva Bardou added 4 commits

    added 4 commits

    • 364d4ec1 - Start working on selected elements deletion
    • 4ecd0229 - Refactor selected elements deletion endpoint
    • 5d7eb340 - Add tests
    • b39f09fc - Fix some review related code snippets

    Compare with previous version

  • Erwan Rouchet
  • Erwan Rouchet resolved all threads

    resolved all threads

  • Erwan Rouchet resolved all threads

    resolved all threads

  • Erwan Rouchet added 1 commit

    added 1 commit

    • 50585baa - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Erwan Rouchet resolved all threads

    resolved all threads

  • Erwan Rouchet added 10 commits

    added 10 commits

    Compare with previous version

  • The batch thing definitely is a hack and I expect some complaints about "why are there 1000 tasks‽" to come in, but I guess it will do for now…

  • Erwan Rouchet approved this merge request

    approved this merge request

  • Erwan Rouchet enabled an automatic merge when the pipeline for 0ff1bb8a succeeds

    enabled an automatic merge when the pipeline for 0ff1bb8a succeeds

  • merged

  • Erwan Rouchet mentioned in commit 12948ce3

    mentioned in commit 12948ce3

  • Please register or sign in to reply
    Loading