Add request user membership level retrieving details of a group
Depends on !1106 (merged) and !1108 (merged)
Sould be rebased on !1124 (merged)
Closes #566 (closed)
Serialize the request member level when making a GET/PATCH/POST on a group.
Allows to evaluate rights on a group in the frontend.
Merge request reports
Activity
Codecov Report
Merging #1112 (1e719723) into master (a0232305) will increase coverage by
0.00%
. The diff coverage is95.83%
.@@ Coverage Diff @@ ## master #1112 +/- ## ======================================= Coverage 88.09% 88.10% ======================================= Files 246 246 Lines 16612 16616 +4 ======================================= + Hits 14635 14640 +5 + Misses 1977 1976 -1
Impacted Files Coverage Δ arkindex/project/api_v1.py 100.00% <ø> (ø)
arkindex/users/api.py 88.77% <90.00%> (-0.24%)
arkindex/users/serializers.py 98.78% <100.00%> (+0.04%)
arkindex/users/tests/test_membership.py 100.00% <100.00%> (ø)
arkindex/documents/tests/test_classes.py 100.00% <0.00%> (+0.77%)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a023230...1e71972. Read the comment docs.Edited by Bastien Abadie- Resolved by Valentin Rigal
@babadie @erwanrouchet what do you think about implications of this MR ? Two different serializers will be used for group:
- Retrieving a group
'id': <uuid>, 'name': <str>, 'public': <bool>, 'members_count': <int>, 'level': <int>
- Listing memberships
'group': { 'id': <uuid>, 'name': <str>, 'public': <bool>, 'members_count': <int>, }, 'level': <int>, 'id': <uuid>
The idea is to allow @chloe.dubois continue the frontend work if this works theoretically
Edited by Valentin Rigal
added 12 commits
-
75d9879f...bfcb90b2 - 6 commits from branch
master
- f291842d - Member details
- 591a1a77 - Update endpoint path
- ea5f1d17 - Serialize request user membership level in group POST/GET/PUT endpoints
- 11d286f3 - Update API doc
- 4f778b09 - Use a different group field serializer for ListMemberships endpoint
- 5733ddd1 - Update tests
Toggle commit list-
75d9879f...bfcb90b2 - 6 commits from branch
added 16 commits
-
5733ddd1...ada6a281 - 10 commits from branch
master
- 0bfb3a58 - Member details
- 7a234d02 - Update endpoint path
- 8085ee5b - Serialize request user membership level in group POST/GET/PUT endpoints
- 86657fb0 - Update API doc
- cf3a818b - Use a different group field serializer for ListMemberships endpoint
- b0509764 - Update tests
Toggle commit list-
5733ddd1...ada6a281 - 10 commits from branch
added 14 commits
-
b0509764...b88d383a - 10 commits from branch
master
- 08bdea6d - Serialize request user membership level in group POST/GET/PUT endpoints
- b715f9f2 - Update API doc
- df7e6572 - Use a different group field serializer for ListMemberships endpoint
- de9a6be8 - Update tests
Toggle commit list-
b0509764...b88d383a - 10 commits from branch
assigned to @babadie
mentioned in merge request !1124 (merged)
assigned to @erwanrouchet and unassigned @babadie
added 17 commits
-
de9a6be8...439bdae2 - 13 commits from branch
master
- a866f762 - Serialize request user membership level in group POST/GET/PUT endpoints
- c9ff1a16 - Update API doc
- fd542cb9 - Use a different group field serializer for ListMemberships endpoint
- af94140a - Update tests
Toggle commit list-
de9a6be8...439bdae2 - 13 commits from branch
added 10 commits
-
af94140a...a61a3293 - 6 commits from branch
master
- bf241435 - Serialize request user membership level in group POST/GET/PUT endpoints
- 7f635171 - Update API doc
- 1425696a - Use a different group field serializer for ListMemberships endpoint
- 7dc571a3 - Update tests
Toggle commit list-
af94140a...a61a3293 - 6 commits from branch
added 10 commits
-
7dc571a3...a0232305 - 6 commits from branch
master
- 1d967096 - Serialize request user membership level in group POST/GET/PUT endpoints
- f494c63d - Update API doc
- 5b59f216 - Use a different group field serializer for ListMemberships endpoint
- 1e719723 - Update tests
Toggle commit list-
7dc571a3...a0232305 - 6 commits from branch
enabled an automatic merge when the pipeline for 1e719723 succeeds
mentioned in commit 78145b4c