Skip to content
Snippets Groups Projects

Optimize Element.remove_child

Merged Erwan Rouchet requested to merge optimize-remove-child into master

Requires !1406 (merged)

While spending a lot of time updating all the SQL assertions, I noticed Element.remove_child made a lot of unnecessary queries and loaded unnecessary columns and models. I made some quick changes that should avoid loading child element UUIDs in RAM and avoid making one SQL query for each child element. There is definitely room for more improvement should we ever switch to full-SQL path manipulation methods, but this is a quick win.

Edited by Erwan Rouchet

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Bastien AbadieBastien Abadie 3 years ago (Jul 26, 2021 10:12am UTC)

Merge details

  • Changes merged into master with 32d7af3f (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading