Skip to content
Snippets Groups Projects

Fix transcription bulk saving with semicolons

Merged Erwan Rouchet requested to merge fix-ml-results into master
All threads resolved!

Including a semicolon in a transcription text breaks the bulk saving. This fixes it by using tabs instead.

Merge request reports

Checking pipeline status.

Approved by

Merged by Bastien AbadieBastien Abadie 6 years ago (Nov 12, 2018 11:43am UTC)

Merge details

  • Changes merged into master with 04ae0b8b (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Codecov Report

    Merging #153 into master will increase coverage by 0.05%. The diff coverage is 100%.

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##           master     #153      +/-   ##
    ==========================================
    + Coverage   71.69%   71.75%   +0.05%     
    ==========================================
      Files         176      176              
      Lines        7709     7725      +16     
    ==========================================
    + Hits         5527     5543      +16     
      Misses       2182     2182
    Impacted Files Coverage Δ
    arkindex/images/importer.py 33.89% <100%> (ø) :arrow_up:
    arkindex/dataimport/tests/test_tasks.py 100% <100%> (ø) :arrow_up:

    Continue to review full report at Codecov.

    Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5c3ade...4e94ff9. Read the comment docs.

    Edited by Bastien Abadie
  • Bastien Abadie approved this merge request

    approved this merge request

  • Erwan Rouchet added 1 commit

    added 1 commit

    • 77214e56 - Check for some transcriptions

    Compare with previous version

  • Erwan Rouchet added 1 commit

    added 1 commit

    • 4e94ff9d - Check for some transcriptions

    Compare with previous version

  • Erwan Rouchet resolved all discussions

    resolved all discussions

  • Bastien Abadie mentioned in commit 04ae0b8b

    mentioned in commit 04ae0b8b

  • Please register or sign in to reply
    Loading