Skip to content
Snippets Groups Projects

Bump to Python 3.8

Merged Erwan Rouchet requested to merge py3.8 into master
All threads resolved!

Closes #573 (closed), closes #899 (closed)

This will require a base image build (git tag base-python-3.8) to work.

It seems #573 (closed) was caused by some changes in Python's implementation of list(…) and collections.abc.Sequence.__getitem__, which causes multiple calls to BulkMap.__len__ to be made. I could not understand a single thing from CPython's git repo, so I just chose to cache the queryset's length as an attribute of the BulkMap.

Edited by Erwan Rouchet

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Erwan Rouchet resolved all threads

    resolved all threads

  • Erwan Rouchet added 1 commit

    added 1 commit

    • 9d522c8c - Remove pre-commit default language version

    Compare with previous version

  • Bastien Abadie added 14 commits

    added 14 commits

    Compare with previous version

  • I just tested a local build of all 3 images (base + normal + binary) and ran both high level images locally without issues.

  • Bastien Abadie mentioned in commit d1399488

    mentioned in commit d1399488

  • Please register or sign in to reply
    Loading