Refresh OAuth tokens
Closes #1037 (closed)
This removes a lot of unused arguments on GitlabProvider
and GitlabOAuthProvider
, as they were quite confusing and probably introduced bugs when using GitLab instances other than gitlab.com. This fixes some unit tests that were not testing anything properly or could be influenced by various settings, removes some unused mocks, and replaces some mocks with responses
. The providers now only require HTTP requests when they actually have some data to get from the request, not when they just want to generate URLs, so that manage.py
commands will be able to refresh OAuth tokens.
Merge request reports
Activity
mentioned in issue #1040 (closed)
added 23 commits
-
8dcd1231...74487e31 - 14 commits from branch
master
- 10ac2d30 - Add OAuthProvider.refresh_token
- a5898601 - Call refresh_token on Gitlab client instanciation
- bbb6a947 - Remove request from provider classes
- d13a9ea8 - Fix existing tests with non-expired credentials
- 084f5a8a - Test stubs for auto refresh
- a1e9ba1b - Cleanup provider args
- a77b71ae - Fix tests
- 9622ade6 - Make public_hostname required
- fc758ef4 - Fixes after local tests
Toggle commit list-
8dcd1231...74487e31 - 14 commits from branch
requested review from @babadie
- Resolved by Erwan Rouchet
Issues on CI about missing public_hostname ! @erwanrouchet
Edited by Ghost User
added 15 commits
-
0c4306c1...f7decd37 - 2 commits from branch
master
- e81e7bb3 - Add OAuthProvider.refresh_token
- 4c65b493 - Call refresh_token on Gitlab client instanciation
- 4b405a38 - Remove request from provider classes
- c50c3d48 - Fix existing tests with non-expired credentials
- c5030abb - Test stubs for auto refresh
- 8735791a - Cleanup provider args
- ba7dec97 - Fix tests
- a64249f5 - Make public_hostname required
- 43852e98 - Fixes after local tests
- 5497b716 - Fix CI
- 7894905a - Another fix
- ebe5129e - Yet another fix
- 401aeb69 - Fix config in backend-static
Toggle commit list-
0c4306c1...f7decd37 - 2 commits from branch
- Resolved by Bastien Abadie
- Automatically resolved by Erwan Rouchet
added 14 commits
- 93c020c8 - Add OAuthProvider.refresh_token
- 9ec89ef5 - Call refresh_token on Gitlab client instanciation
- 7f811fc5 - Remove request from provider classes
- 46aac2fd - Fix existing tests with non-expired credentials
- 40da0769 - Test stubs for auto refresh
- e97f4bc7 - Cleanup provider args
- ec9d13eb - Fix tests
- 87dc182a - Make public_hostname required
- 2e160826 - Fixes after local tests
- 3175b64e - Fix CI
- 6bcf8a16 - Another fix
- 9c8b100a - Yet another fix
- 66965d5c - Fix config in backend-static
- 2d36a330 - Set error state on error
Toggle commit listmentioned in commit 1bafaf5f