Skip to content
Snippets Groups Projects

Refresh OAuth tokens

Merged Erwan Rouchet requested to merge oauth-refresh into master
All threads resolved!

Closes #1037 (closed)

This removes a lot of unused arguments on GitlabProvider and GitlabOAuthProvider, as they were quite confusing and probably introduced bugs when using GitLab instances other than gitlab.com. This fixes some unit tests that were not testing anything properly or could be influenced by various settings, removes some unused mocks, and replaces some mocks with responses. The providers now only require HTTP requests when they actually have some data to get from the request, not when they just want to generate URLs, so that manage.py commands will be able to refresh OAuth tokens.

Edited by Erwan Rouchet

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Bastien AbadieBastien Abadie 3 years ago (May 20, 2022 1:56pm UTC)

Merge details

  • Changes merged into master with 1bafaf5f (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bastien Abadie
  • Tested locally with my own gitlab app, I was able to connect an account, restore a failed token, and automatically refresh an expired token :ok_hand:

  • Erwan Rouchet added 14 commits

    added 14 commits

    Compare with previous version

  • Bastien Abadie resolved all threads

    resolved all threads

  • Bastien Abadie mentioned in commit 1bafaf5f

    mentioned in commit 1bafaf5f

  • merged

  • Please register or sign in to reply
    Loading