Skip to content
Snippets Groups Projects

Add export TTL setting

Merged Erwan Rouchet requested to merge export-ttl into master
All threads resolved!

Closes #1573 (closed)

I'm not sure if setting the TTL in minutes is a good idea, rather than seconds. We already have the worker_activity_timeout, license.ping_frequency and the 8 RQ timeouts in job_timeouts that all use seconds instead of minutes. I at least made the unit explicit in the code, but it will not be clear to sysadmins that this is the only setting out of 11 that uses minutes rather than seconds.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Bastien AbadieBastien Abadie 1 year ago (Aug 24, 2023 7:26am UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I also think using seconds would be cleaner from an admin point of view.

    Eventually we could use a more explicit message (e.g. "You have to wait XX minutes before starting a new export for this project."). humanize.time.precisedelta may help using a readable timedelta for the user.

  • Erwan Rouchet resolved all threads

    resolved all threads

  • Erwan Rouchet added 1 commit

    added 1 commit

    Compare with previous version

  • Valentin Rigal approved this merge request

    approved this merge request

  • Valentin Rigal requested review from @babadie and removed review request for @vrigal

    requested review from @babadie and removed review request for @vrigal

  • OK for seconds

  • Bastien Abadie added 8 commits

    added 8 commits

    Compare with previous version

  • Bastien Abadie enabled an automatic merge when the pipeline for 9b9fdefa succeeds

    enabled an automatic merge when the pipeline for 9b9fdefa succeeds

  • merged

  • Please register or sign in to reply
    Loading