Skip to content
Snippets Groups Projects

Serve metrics for Prometheus

Merged Valentin Rigal requested to merge prometheus-metrics into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Valentin Rigal
  • Valentin Rigal added 1 commit

    added 1 commit

    Compare with previous version

  • Valentin Rigal resolved all threads

    resolved all threads

  • Valentin Rigal added 1 commit

    added 1 commit

    Compare with previous version

  • Bastien Abadie
  • Valentin Rigal resolved all threads

    resolved all threads

  • Valentin Rigal added 2 commits

    added 2 commits

    Compare with previous version

  • Bastien Abadie added 10 commits

    added 10 commits

    Compare with previous version

  • Bastien Abadie added 1 commit

    added 1 commit

    • 53e2b1ab - Use text/plain + port from config

    Compare with previous version

  • I noticed that ./arkindex/manage.py gunicorn did not work, crashing on the int parse of None (default arg for metrics port).

    I decided to simplify the logic:

    • configure the port from YAML config, so it's more standard
    • always have the metrics port set, default to 3000
    • use the same setting in view & gunicorn
    • no --metrics-port cli arg

    I also set the response content type to text/plain as it's expected by the prometheus client (I did not tell you do to it though).

  • Bastien Abadie added 1 commit

    added 1 commit

    • 41e1668e - Remove metrics port from dockerfiles

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading