Optimizations
- Prefetch classifications and transcriptions with sources on page API (removes duplicate SQL requests)
- Disconnect the Django pre_delete signal when deleting a corpus; although there are no ElementPaths, Django will still fetch every element and run the signal. Disconnecting speeds up the corpus deletion command by ~600%.
- Remove the .tar.gz after installing in Dockerfile
Edited by Erwan Rouchet
Merge request reports
Activity
added 4 commits
-
9588b639...29829d91 - 2 commits from branch
master
- eaa489ea - Prefetch classifications and transcriptions with source on page details API
- 7ab575d4 - Temporarily disconnect the pre_delete signal when deleting elements
-
9588b639...29829d91 - 2 commits from branch
added 1 commit
- bfcd3d2b - WIP: Try to debug a non-reproducible bug in GitLab CI
added 1 commit
- ef49d142 - WIP: Try to debug a non-reproducible bug in GitLab CI
added 1 commit
- adc56ef7 - WIP: Try to debug a non-reproducible bug in GitLab CI
added 1 commit
- 749eb342 - WIP: Try to debug a non-reproducible bug in GitLab CI
Codecov Report
Merging #220 into master will increase coverage by
0.03%
. The diff coverage is95.65%
.@@ Coverage Diff @@ ## master #220 +/- ## ========================================== + Coverage 78.33% 78.37% +0.03% ========================================== Files 143 143 Lines 8350 8365 +15 ========================================== + Hits 6541 6556 +15 Misses 1809 1809
Impacted Files Coverage Δ arkindex/documents/api/elements.py 76.19% <0%> (ø)
arkindex/project/tools.py 79.68% <100%> (+2.9%)
...dex/documents/tests/commands/test_delete_corpus.py 100% <100%> (ø)
...dex/documents/management/commands/delete_corpus.py 100% <100%> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3113bfc...a48ec42. Read the comment docs.Edited by Bastien Abadieadded 7 commits
-
749eb342...2c8037e2 - 4 commits from branch
master
- a0ea3ac7 - Prefetch classifications and transcriptions with source on page details API
- adc31d9c - Temporarily disconnect the pre_delete signal when deleting elements
- f7eea32f - WIP: Try to debug a non-reproducible bug in GitLab CI
Toggle commit list-
749eb342...2c8037e2 - 4 commits from branch
added 6 commits
-
51190ba7...3113bfc2 - 2 commits from branch
master
- 14d12883 - Prefetch classifications and transcriptions with source on page details API
- ca93dfc0 - Temporarily disconnect the pre_delete signal when deleting elements
- 36a4eb35 - Remove .tar.gz after installing in Dockerfile
- a48ec420 - Properly disconnect the pre_delete signal
Toggle commit list-
51190ba7...3113bfc2 - 2 commits from branch
enabled an automatic merge when the pipeline for a48ec420 succeeds
mentioned in commit 00c55049
Please register or sign in to reply