Remove ProcessMode Repository

closes #1706 (closed)

(1) I made the corpus created in the migration to house the ex-Repository process public to avoid rights issues, but that's probably not ideal as it's a weird little fake corpus and it being public is strange. Maybe the better thing to do would be to give every existing user Guest access on it, and then also give Guest access to it to the default group to which all new users are added by default, if that's still a thing? I don't really remember how / if that works.

(2) I think the migrations work but I'm not 100% sure; they worked for my local DB with Repository processes in it, and they also work for the test DB which is being created every time, so it looks like they do?

I had trouble handling the fact that ProcessMode.Repository is present in a constraint on Process: at first I had just put a migrations.RemoveConstraint but that didn't work because the constraint is there in the inital process migrations, which failed when the ProcessMode enum was changed to remove Repository. Then I just removed the constraint from the initial migrations, as in the new ones I replace it with another one (either the process is Local or it has a corpus).

But I am Afraid it only looks like it works because of how I had initially removed the constraint and otherwise I'd be getting an error telling me a constraint with that name already exists.

arkindex/process/migrations/0003_initial.py

@@ -3,12 +3,18 @@
 import django.db.models.deletion
 from django.conf import settings
 from django.db import migrations, models
+from enumfields import Enum, fields
 
 import arkindex.process.models
 import pgtrigger.compiler
 import pgtrigger.migrations
 
 
+class TmpProcessMode(Enum):
+    Repository = "repository"
+    Local = "local"
+
+
 class Migration(migrations.Migration):
 
     initial = True
@@ -187,13 +193,27 @@ class Migration(migrations.Migration):
             name="processelement",
             unique_together={("process", "element")},
         ),
+        migrations.AddConstraint(
+            model_name="process",
+            constraint=models.UniqueConstraint(models.F("creator"), condition=models.Q(("mode", arkindex.process.models.ProcessMode["Local"])), name="unique_local_process", violation_error_message="Only one local process is allowed per user."),
+        ),
         migrations.AddConstraint(
             model_name="process",
             constraint=models.CheckConstraint(check=models.Q(models.Q(("mode", arkindex.process.models.ProcessMode["Local"]), _negated=True), ("workflow", None), _connector="OR"), name="local_process_no_workflow", violation_error_message="Local processes cannot be started."),
         ),
+        migrations.AlterField(
+            model_name="process",
+            name="mode",
+            field=fields.EnumField(enum=TmpProcessMode, max_length=30)
+        ),
         migrations.AddConstraint(
             model_name="process",
-            constraint=models.UniqueConstraint(models.F("creator"), condition=models.Q(("mode", arkindex.process.models.ProcessMode["Local"])), name="unique_local_process", violation_error_message="Only one local process is allowed per user."),
+            constraint=models.CheckConstraint(check=models.Q(("mode__in", (TmpProcessMode["Local"], TmpProcessMode["Repository"])), models.Q(("corpus", None), _negated=True), _connector="XOR"), name="check_process_corpus", violation_error_message="Local and repository processes cannot have a corpus, and other modes must have one set."),
+        ),
+        migrations.AlterField(
+            model_name="process",
+            name="mode",
+            field=fields.EnumField(enum=arkindex.process.models.ProcessMode, max_length=30)
         ),
         migrations.AlterUniqueTogether(
             name="gitref",