Skip to content
Snippets Groups Projects

Always enable WorkerRun.use_gpu on versions requiring GPUs

Merged Erwan Rouchet requested to merge use-gpu-harder into master

WorkerRuns on templates were found to have use_gpu disabled after the migration in !2351 (merged), even though their WorkerVersion had gpu_usage set to Required. That was because on template processes, Process.use_gpu was always False, and the migration relied on Process.use_gpu to make its decision.

I updated the migration to always set WorkerRun.use_gpu when a version requires GPU usage. When a version supports GPU usage, it is only enabled on the WorkerRun if it was enabled in the process, which was the previous behavior when we had use_gpu on processes.

I already ran the queries manually in preprod, prod and demo to apply this change and get MLProd unstuck.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Valentin RigalValentin Rigal 8 months ago (Aug 12, 2024 2:00pm UTC)

Merge details

  • Changes merged into master with 1fbca041 (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading