Skip to content
Snippets Groups Projects

Use JSON for all test requests

Merged Erwan Rouchet requested to merge test-requests-json into master

Requires !2418 (merged), closes #1829 (closed)

Making the switch showed a bug in CreateElementChildren: calling it with {"children": []} did not cause an error as expected. Since the multipart format does not support lists at all, it sent nothing, so the endpoint interpreted it as a required field being missing rather than a field set to an empty list, so the bug went unnoticed.

I removed all of the format="json" we were using in the requests to force the format when the multipart format was causing us trouble, since it is now the default.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Bastien AbadieBastien Abadie 7 months ago (Aug 27, 2024 9:06am UTC)

Merge details

  • Changes merged into master with 220d5c94 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading