Skip to content
Snippets Groups Projects

Fix max orderings in CreateElementChildren

Merged Erwan Rouchet requested to merge fix-createelementchildren-max-orderings into master
All threads resolved!

Closes #1834 (closed)

The missing .values("path") meant that Django was not adding any GROUP BY when calculating max orderings for each path. This means that when there is more than one child element already present on the parent, there would be multiple maximum orderings per path, and the dict comprehension just picked whatever value got returned first and discard the rest. I added a second child element in an existing test and reproduced the issue, then fixed it with the .values("path").

Merge request reports

Checking pipeline status.

Merged by Bastien AbadieBastien Abadie 7 months ago (Sep 4, 2024 11:57am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bastien Abadie requested changes

    requested changes

  • Bastien Abadie resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading