Support feature worker declaration from gitlab.teklia.com

Closes #1883 (closed)

• Requires tests

changed milestone to %Arkindex 1.7.1

assigned to @vrigal

marked this merge request as draft

I was not able to add tests for configuration extra checks (due to mocking issues). I tested carefully though and was able to replace the init worker easily. I'm adding a few tests mocking requests calls.

--- a/arkindex/system_workers.yml
+++ b/arkindex/system_workers.yml
@@ -4,8 +4,6 @@
 version: 1.7.1-rc1

 features:
-    file_import:
-        image: registry.gitlab.teklia.com/arkindex/workers/import/file:0.1.1
     init_elements:
         image: registry.gitlab.teklia.com/arkindex/workers/init-elements:0.1.1
         command: worker-init-elements
@@ -20,3 +18,8 @@ features:
     docx_export:
         image: registry.gitlab.teklia.com/arkindex/workers/export:0.2.1-rc1
         command: worker-export-docx
+    file_import:
+        teklia_worker:
+            name: arkindex/workers/import/file
+            version: 0.1.1
+            slug: file-import

added 6 commits

• ca0ead32 - Parse .arkindex.yml with the new declaration of features
• 146f6541 - Support configuration in existing check and creation
• 2e05313e - Pass attributes directly
• dc1f2c81 - Avoid invalidating workers with a configuration set via the docker command
• dcb34016 - Update tests
• 44ca3abf - WIP: Add tests

Compare with previous version

added 2 commits

• d2f4ac1c - Store repository_url for newly created worker
• 2d70bd3b - Add tests

Compare with previous version

marked the checklist item Requires tests as completed

marked this merge request as ready

requested review from @babadie

added 13 commits

• 2d70bd3b...49143aab - 4 commits from branch release-1.7.1
• a03f8772 - Add options to the command
• 940ff674 - Add a bit of validation
• 43569556 - Parse .arkindex.yml with the new declaration of features
• 4c27ac0a - Support configuration in existing check and creation
• a1981f31 - Pass attributes directly
• 7ef490d2 - Avoid invalidating workers with a configuration set via the docker command
• 322d5ee1 - Update tests
• 9d05fd3a - Store repository_url for newly created worker
• 602eba34 - Add tests

Compare with previous version

added 1 commit

• 8b94be5a - Use teklia_worker for exports

Compare with previous version

This works nicely, code looks good (no real comment), only issue is that re-running it with the same config will re-create new worker versions due to a custom docker image

────────────────────────────────── ExportPDF ───────────────────────────────────
Configuring feature Exportpdf from https://gitlab.teklia.com/arkindex/workers/export
Using registry.gitlab.teklia.com/arkindex/workers/export/0.2.1-rc1 to provide ExportPDF
Current worker version: aed7e91c-6301-49e1-954c-3a7ec32ae6bf (registry.gitlab.teklia.com/arkindex/workers/export/0.2.1-rc1)
This version uses a custom Docker command which could interfere with the feature.
Unassigning feature from the current version
Worker is up to date
Creating new worker version
Using new worker version 269ca3be-26b6-4a26-b98f-a1002359c9b6

I pushed a commit on this MR to update the configuration with required values for export workers

Oops, it seems I have missed this case. I will write a test that cover this case and push a fix.

added 2 commits

• 0c235f08 - Update test cases
• 35f08f0b - Fix docker command comparison for workers declared from .arkindex.yml

Compare with previous version

@babadie it should be working as expected now.

enabled an automatic merge when all merge checks for 35f08f0b pass

resolved all threads

merged