Skip to content
Snippets Groups Projects

Dates in search api

Merged Valentin Rigal requested to merge dates-in-search-api into master

requires !266 (merged)

Todo

  • Defensive on user submitted form
  • Unit tests

Checking dates order (lower_bound < upper_bound) will be effecticve in PR !272 (merged)

Edited by Valentin Rigal

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Erwan RouchetErwan Rouchet 6 years ago (Apr 8, 2019 2:53pm UTC)

Merge details

  • Changes merged into with e089f259.
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Valentin Rigal added 1 commit

    added 1 commit

    • 9ee5ac19 - basic test for SearchApiMixin ES json query rendering

    Compare with previous version

  • Codecov Report

    Merging #267 into master will increase coverage by 0.17%. The diff coverage is 100%.

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##           master     #267      +/-   ##
    ==========================================
    + Coverage   79.53%   79.71%   +0.17%     
    ==========================================
      Files         161      162       +1     
      Lines        9622     9686      +64     
    ==========================================
    + Hits         7653     7721      +68     
    + Misses       1969     1965       -4
    Impacted Files Coverage Δ
    arkindex/documents/api/search.py 100% <ø> (ø) :arrow_up:
    arkindex/project/mixins.py 86.15% <100%> (+5.55%) :arrow_up:
    arkindex/project/serializer_fields.py 100% <100%> (ø) :arrow_up:
    arkindex/documents/tests/test_search_api.py 100% <100%> (ø)
    arkindex/documents/serializers/search.py 100% <100%> (ø) :arrow_up:

    Continue to review full report at Codecov.

    Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2628630...fe971da. Read the comment docs.

    Edited by Bastien Abadie
  • Valentin Rigal resolved all discussions

    resolved all discussions

  • Valentin Rigal resolved all discussions

    resolved all discussions

  • Valentin Rigal added 1 commit

    added 1 commit

    • 97941f36 - removed date_relation as API parameter

    Compare with previous version

  • Valentin Rigal marked as a Work In Progress

    marked as a Work In Progress

  • Valentin Rigal changed the description

    changed the description

  • Valentin Rigal marked the checklist item Defensive on user submitted form as completed

    marked the checklist item Defensive on user submitted form as completed

  • Valentin Rigal marked the checklist item Defensive on user submitted form as incomplete

    marked the checklist item Defensive on user submitted form as incomplete

  • Valentin Rigal added 2 commits

    added 2 commits

    • 963ae40a - date_validator method
    • 2899fc1d - WIP: client parameters validation during search

    Compare with previous version

  • Valentin Rigal marked the checklist item Defensive on user submitted form as completed

    marked the checklist item Defensive on user submitted form as completed

  • Valentin Rigal changed the description

    changed the description

  • Valentin Rigal resolved all discussions

    resolved all discussions

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading