Skip to content
Snippets Groups Projects

Use best classes attribute to filter endpoints that lists elements

Merged Valentin Rigal requested to merge best-classes-filter into master
All threads resolved!

affected endpoints:

  • ListElements
  • ListElementParents
  • ListElementChildren

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Erwan Rouchet
  • Valentin Rigal added 1 commit

    added 1 commit

    • 25012cbd - Add specific test for unset best_classes argument

    Compare with previous version

  • Codecov Report

    Merging #547 into master will decrease coverage by 0.02%. The diff coverage is 96%.

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##           master     #547      +/-   ##
    ==========================================
    - Coverage   84.35%   84.32%   -0.03%     
    ==========================================
      Files         209      210       +1     
      Lines       12441    12425      -16     
    ==========================================
    - Hits        10495    10478      -17     
    - Misses       1946     1947       +1
    Impacted Files Coverage Δ
    arkindex/documents/api/ml.py 97.07% <ø> (ø) :arrow_up:
    ...kindex/documents/tests/test_bulk_classification.py 100% <ø> (ø) :arrow_up:
    arkindex/documents/models.py 33.44% <0%> (-0.12%) :arrow_down:
    arkindex/documents/tests/test_classes.py 100% <100%> (ø) :arrow_up:
    ...x/documents/migrations/0027_classification_best.py 100% <100%> (ø)
    arkindex/documents/api/elements.py 94.95% <100%> (-0.4%) :arrow_down:
    arkindex/documents/tests/test_moderation.py 100% <100%> (ø) :arrow_up:
    arkindex/documents/serializers/ml.py 95.6% <100%> (+0.09%) :arrow_up:

    Continue to review full report at Codecov.

    Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69ea693...d0dffde. Read the comment docs.

    Edited by Bastien Abadie
  • Valentin Rigal added 1 commit

    added 1 commit

    • d0dffde1 - Add specific test for unset best_classes argument

    Compare with previous version

  • Valentin Rigal resolved all threads

    resolved all threads

  • merged

  • Erwan Rouchet mentioned in commit 1708f442

    mentioned in commit 1708f442

  • Erwan Rouchet mentioned in merge request !546 (closed)

    mentioned in merge request !546 (closed)

  • Please register or sign in to reply
    Loading