Skip to content
Snippets Groups Projects

Structural metadata

Merged Structural metadata
structure-metadata into master
All threads resolved!
Merged Valentin Rigal requested to merge structure-metadata into master
All threads resolved!

requires common!51

Edited by Valentin Rigal

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Erwan RouchetErwan Rouchet 5 years ago (Jan 6, 2020 2:25pm UTC)

Merge details

  • Changes merged into master with b0d26503 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Valentin Rigal resolved all threads

    resolved all threads

  • Valentin Rigal added 21 commits

    added 21 commits

    • b19cd7bf...72e63dff - 2 commits from branch master
    • 6e3c6593 - Migrate structure metadata
    • e5ff2345 - Index structure metadata in ES
    • 4cc1145e - Add structure metadata filter in filtered ListElement endpoints
    • d2222391 - Handle BALSAC data in migration
    • 12ec4f50 - Case insensitive structure filter
    • 9b2c47af - Search indexed structural metadata
    • 1b677d14 - Switch to structural MetaType
    • 0ffe0025 - ESElement dumb test
    • 06611b31 - Test structural filter on ListElement endpoints
    • 304de6c0 - rebase migration
    • b6f669ab - Revert "Test structural filter on ListElement endpoints"
    • 293cc17e - Revert "Add structure metadata filter in filtered ListElement endpoints"
    • f7fa1394 - Compare lowercase structural metadata
    • f6a00f29 - Update migration metadata type and name
    • 8b115acd - Move name from structural to reference
    • cc7cc76d - Fixup tests
    • 1b703462 - update migration file again
    • f3b81a19 - Use terms field to find elements by reference
    • 795540a4 - WIP: SimpleText query for references

    Compare with previous version

    Toggle commit list
  • Valentin Rigal marked as a Work In Progress from 795540a4

    marked as a Work In Progress from 795540a4

  • Valentin Rigal added 24 commits

    added 24 commits

    • 795540a4...7be51908 - 6 commits from branch master
    • c164b9da - Migrate structure metadata
    • afec18b3 - Index structure metadata in ES
    • 67a7bf54 - Add structure metadata filter in filtered ListElement endpoints
    • 2f24038a - Handle BALSAC data in migration
    • 6572600b - Case insensitive structure filter
    • 8247f7c3 - Search indexed structural metadata
    • c25b0a11 - Switch to structural MetaType
    • c7e56498 - ESElement dumb test
    • ddb1a98b - Test structural filter on ListElement endpoints
    • c3b2a9b1 - rebase migration
    • 5b56c556 - Revert "Test structural filter on ListElement endpoints"
    • 25a02e02 - Revert "Add structure metadata filter in filtered ListElement endpoints"
    • a3772ed1 - Compare lowercase structural metadata
    • 0862066f - Update migration metadata type and name
    • 74b287ad - Move name from structural to reference
    • 6c6012a6 - Fixup tests
    • 90656c43 - update migration file again
    • 5977b03f - Use terms field to find elements by reference

    Compare with previous version

    Toggle commit list
  • Erwan Rouchet
  • Valentin Rigal resolved all threads

    resolved all threads

  • Valentin Rigal added 27 commits

    added 27 commits

    • 5977b03f...f996e579 - 7 commits from branch master
    • a7eb7aeb - Migrate structure metadata
    • 4e79fa7e - Index structure metadata in ES
    • 24c31591 - Add structure metadata filter in filtered ListElement endpoints
    • 8a3b69d1 - Handle BALSAC data in migration
    • 49f3bfa5 - Case insensitive structure filter
    • 3991921c - Search indexed structural metadata
    • e44e6028 - Switch to structural MetaType
    • 8acbbdd0 - ESElement dumb test
    • 4058e0ca - Test structural filter on ListElement endpoints
    • 94a658ae - rebase migration
    • efab4c95 - Revert "Test structural filter on ListElement endpoints"
    • 39f77391 - Revert "Add structure metadata filter in filtered ListElement endpoints"
    • 452cd6c8 - Compare lowercase structural metadata
    • 54c4f8c8 - Update migration metadata type and name
    • 7eb2fa41 - Move name from structural to reference
    • 23576fcc - Fixup tests
    • f3821255 - update migration file again
    • f24fbc9c - Use terms field to find elements by reference
    • 2cf28e16 - Rebase migration
    • d38ff32d - Succint ES test

    Compare with previous version

    Toggle commit list
  • Bastien Abadie
    Bastien Abadie @babadie ·
    Owner

    Codecov Report

    Merging #581 into master will increase coverage by 0.04%. The diff coverage is 88.23%.

    Impacted file tree graph

    @@            Coverage Diff            @@
##           master    #581      +/-   ##
=========================================
+ Coverage   85.26%   85.3%   +0.04%     
=========================================
  Files         222     223       +1     
  Lines       13380   13424      +44     
=========================================
+ Hits        11408   11452      +44     
  Misses       1972    1972
    Impacted Files Coverage Δ
    arkindex/project/elastic.py 22.36% <0%> (+2.09%) :arrow_up:
    arkindex/documents/tests/test_search.py 100% <100%> (ø) :arrow_up:
    arkindex/documents/api/search.py 98% <100%> (+0.12%) :arrow_up:
    arkindex/project/tests/test_elastic.py 100% <100%> (ø) :arrow_up:
    ...ocuments/migrations/0031_remove_entity_metatype.py 35.48% <33.33%> (-2.45%) :arrow_down:
    ...x/documents/migrations/0032_structural_metadata.py 90.9% <90.9%> (ø)
    arkindex/project/polygon.py 50.93% <0%> (+2.48%) :arrow_up:

    Continue to review full report at Codecov.

    Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3173103...501bc5a. Read the comment docs.

    Edited by Bastien Abadie
  • Valentin Rigal unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Erwan Rouchet
  • Erwan Rouchet
  • Valentin Rigal resolved all threads

    resolved all threads

  • Valentin Rigal added 1 commit

    added 1 commit

    Compare with previous version

  • Valentin Rigal added 24 commits

    added 24 commits

    • f1a1b988...51934246 - 3 commits from branch master
    • 5b3356e1 - Migrate structure metadata
    • 6ca47d20 - Index structure metadata in ES
    • 218cc1e3 - Add structure metadata filter in filtered ListElement endpoints
    • 41926bfa - Handle BALSAC data in migration
    • 67e2cab9 - Case insensitive structure filter
    • 8d6fc2c4 - Search indexed structural metadata
    • 1eb9c5ac - Switch to structural MetaType
    • 7be9f672 - ESElement dumb test
    • 9ff93be0 - Test structural filter on ListElement endpoints
    • d8dc7298 - rebase migration
    • f743c53e - Revert "Test structural filter on ListElement endpoints"
    • 405a33b5 - Revert "Add structure metadata filter in filtered ListElement endpoints"
    • ca5fd984 - Compare lowercase structural metadata
    • 4d3897ef - Update migration metadata type and name
    • 19122b10 - Move name from structural to reference
    • a54f8f88 - Fixup tests
    • dbd2f6f7 - update migration file again
    • b8afaaee - Use terms field to find elements by reference
    • 462d6f8c - Rebase migration
    • 9bd7a582 - Succint ES test
    • 7c1d165d - Typo

    Compare with previous version

    Toggle commit list
  • Erwan Rouchet added 35 commits

    added 35 commits

    • 7c1d165d...d93ab814 - 14 commits from branch master
    • 31731035 - Migrate structure metadata
    • 36ded5cc - Index structure metadata in ES
    • eb1b3a51 - Add structure metadata filter in filtered ListElement endpoints
    • b770ea93 - Handle BALSAC data in migration
    • 313b74d1 - Case insensitive structure filter
    • ca312a20 - Search indexed structural metadata
    • d940bab9 - Switch to structural MetaType
    • 892c6044 - ESElement dumb test
    • ebce3d24 - Test structural filter on ListElement endpoints
    • 7079c04b - rebase migration
    • 393a731b - Revert "Test structural filter on ListElement endpoints"
    • b793ee30 - Revert "Add structure metadata filter in filtered ListElement endpoints"
    • 3ef2cfc0 - Compare lowercase structural metadata
    • 0daa84e7 - Update migration metadata type and name
    • 445f50c4 - Move name from structural to reference
    • f08a43ae - Fixup tests
    • 15b0d3aa - update migration file again
    • 32ef4eab - Use terms field to find elements by reference
    • f789986f - Rebase migration
    • c6dd7889 - Succint ES test
    • 501bc5ae - Typo

    Compare with previous version

    Toggle commit list
  • Erwan Rouchet merged

    merged

  • Erwan Rouchet mentioned in commit b0d26503

    mentioned in commit b0d26503

    • Please register or sign in to reply