Bump to Django 3.1
Part of architecture#14. When merging, please create a base-django-3.1
tag!
- Django REST Framework does support Django 3.1 via 3.11.1, a quick release that fixed some broken imports. However, the
ModelSerializer
is unable to translate the new JSONField into a JSON serializer field by itself. This adds one line to the WorkerVersion serializer. https://github.com/encode/django-rest-framework/pull/7467 - Starting with Django 3.0, applying
prefetch_related
on aunion()
of two QuerySets is not allowed; however, we can apply theprefetch_related
to both querysets in the union without any loss in query optimisation. This changesEntityElements.get_queryset
- Starting with Django 3.1,
Meta.ordering
no longer affects queries that have aGROUP BY
. This causes theCorpusMLClassList
endpoint to loose its implicit class name ordering, which has been explicitly restored in its queryset. - An optimization in
DELETE
queries having Q objects combined withOR
causes one less query in the ML results deletion consumer. - Cookie SameSite settings now have two separate options
'None'
(string) andFalse
(boolean) -
django-cors-headers
needed to be upgraded to support Django 3, and this caused a breaking change to be pulled on the origin whitelist, causing protocol schemes to be required (architecture!116) - Django 3 added some complexity to the way it handles iterables as query filters, causing errors on the
Point
constructor. Support forPoint(iterable)
is added alongsidePoint(int, int)
. - One failing test due to common!63; fixed in !867 (merged)
Edited by Erwan Rouchet
Merge request reports
Activity
added 481 commits
-
98cccdae...0d34e569 - 472 commits from branch
master
- dee1d63c - Bump to Django 3.1
- 0190983c - Move to the new JSONField
- 8fa0fc5c - Bump dependencies
- 1675683a - Fix prefetch_related in union
- c3b32c41 - Restore implicit class name ordering
- 0aecc333 - Deletion query optimization
- be4837ff - Update SameSite options
- 575950b2 - Add schemes on CORS origin whitelist
- ce646306 - Add Point(iterable) for queryset compatibility
Toggle commit list-
98cccdae...0d34e569 - 472 commits from branch
assigned to @babadie and unassigned @erwanrouchet
added 15 commits
-
47b8b8b8...9da2f108 - 4 commits from branch
master
- 2bfed043 - Bump to Django 3.1
- b5c44c5f - Move to the new JSONField
- decf2d7f - Bump dependencies
- 01804072 - Fix prefetch_related in union
- 711b7f99 - Restore implicit class name ordering
- 3ce3229f - Deletion query optimization
- 28c23e95 - Update SameSite options
- fe0a0e76 - Add schemes on CORS origin whitelist
- efe7f3fd - Add Point(iterable) for queryset compatibility
- 393ff0e0 - Fix config tests
- 383c7b59 - Update missed base tag
Toggle commit list-
47b8b8b8...9da2f108 - 4 commits from branch
added 17 commits
-
383c7b59...d8314c65 - 6 commits from branch
master
- b73c567b - Bump to Django 3.1
- e9a8ea6b - Move to the new JSONField
- 0a0142cd - Bump dependencies
- 7f542e4e - Fix prefetch_related in union
- 202c82ed - Restore implicit class name ordering
- ac980221 - Deletion query optimization
- 03245dc5 - Update SameSite options
- 3ddea821 - Add schemes on CORS origin whitelist
- c996d34a - Add Point(iterable) for queryset compatibility
- 452501ea - Fix config tests
- c2c0230c - Update missed base tag
Toggle commit list-
383c7b59...d8314c65 - 6 commits from branch
Codecov Report
Merging #656 into master will increase coverage by
0.00%
. The diff coverage is76.47%
.@@ Coverage Diff @@ ## master #656 +/- ## ======================================= Coverage 86.60% 86.60% ======================================= Files 227 228 +1 Lines 14260 14268 +8 ======================================= + Hits 12350 12357 +7 - Misses 1910 1911 +1
Impacted Files Coverage Δ arkindex/dataimport/models.py 43.62% <0.00%> (+0.17%)
arkindex/documents/api/ml.py 97.25% <ø> (ø)
arkindex/project/config.py 85.34% <0.00%> (-0.75%)
arkindex/project/polygon.py 52.04% <66.66%> (+0.56%)
...kindex/dataimport/migrations/0016_new_jsonfield.py 100.00% <100.00%> (ø)
arkindex/dataimport/serializers/workers.py 100.00% <100.00%> (ø)
arkindex/documents/api/entities.py 98.21% <100.00%> (ø)
...uments/tests/consumers/test_ml_results_consumer.py 100.00% <100.00%> (ø)
arkindex/project/tests/test_config.py 98.30% <100.00%> (-1.70%)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d8314c6...c2c0230. Read the comment docs.mentioned in commit 59360cc8
Please register or sign in to reply