Prevent removing parameter overrides on first schema generation
This is ground work for #264 (closed). While working on this issue, I noticed that generating the schema once caused a lot of declared filters to be missing on all the subsequent generations for as long as the server is running; it turns out a .pop()
on a dict caused the overriden parameters to go missing.
The failing test on !759 (merged) demonstrates the issue: https://gitlab.com/arkindex/backend/-/jobs/571343657
Merge request reports
Activity
Codecov Report
Merging #759 into master will increase coverage by
0.00%
. The diff coverage is100.00%
.@@ Coverage Diff @@ ## master #759 +/- ## ======================================= Coverage 86.24% 86.24% ======================================= Files 198 198 Lines 13340 13341 +1 ======================================= + Hits 11505 11506 +1 Misses 1835 1835
Impacted Files Coverage Δ arkindex/project/openapi/schemas.py 96.22% <100.00%> (+0.07%)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 16a52c3...bdad527. Read the comment docs.Edited by Bastien Abadiementioned in merge request api-client!177 (merged)
assigned to @babadie and unassigned @erwanrouchet
mentioned in merge request !760 (merged)
added 5 commits
-
1dea8126...16a52c36 - 4 commits from branch
master
- bdad527d - Prevent issues with multiple schema generations at once
-
1dea8126...16a52c36 - 4 commits from branch
mentioned in commit e99b8e18