Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
Frontend
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Container Registry
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Arkindex
Frontend
Commits
4b3de109
Commit
4b3de109
authored
10 months ago
by
Theo Lesage
Browse files
Options
Downloads
Patches
Plain Diff
Remove call to navigation store in element vuex store
parent
0c5d8356
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!1675
Remove call to navigation store in element vuex store
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/store/elements.js
+0
-2
0 additions, 2 deletions
src/store/elements.js
tests/unit/store/elements.spec.js
+0
-4
0 additions, 4 deletions
tests/unit/store/elements.spec.js
with
0 additions
and
6 deletions
src/store/elements.js
+
0
−
2
View file @
4b3de109
...
...
@@ -317,7 +317,6 @@ export const actions = {
try
{
await
api
.
deleteElement
({
id
,
delete_children
:
true
})
commit
(
'
remove
'
,
id
)
commit
(
'
navigation/addToScheduledDeletion
'
,
id
,
{
root
:
true
})
if
(
id
===
rootState
.
annotation
.
selectedElement
?.
id
)
{
commit
(
'
annotation/selectElement
'
,
null
,
{
root
:
true
})
}
commit
(
'
notifications/notify
'
,
{
type
:
'
success
'
,
text
:
'
Element deletion has been scheduled.
'
},
{
root
:
true
})
}
catch
(
err
)
{
...
...
@@ -332,7 +331,6 @@ export const actions = {
try
{
await
api
.
moveElement
(
payload
)
commit
(
'
remove
'
,
payload
.
source
)
commit
(
'
navigation/addToScheduledDeletion
'
,
payload
.
source
,
{
root
:
true
})
commit
(
'
notifications/notify
'
,
{
type
:
'
success
'
,
text
:
'
Element moving has been scheduled.
'
},
{
root
:
true
})
}
catch
(
err
)
{
commit
(
'
notifications/notify
'
,
{
type
:
'
error
'
,
text
:
errorParser
(
err
)
},
{
root
:
true
})
...
...
This diff is collapsed.
Click to expand it.
tests/unit/store/elements.spec.js
+
0
−
4
View file @
4b3de109
...
...
@@ -599,10 +599,6 @@ describe('elements', () => {
mutation
:
'
elements/remove
'
,
payload
:
'
element
'
},
{
mutation
:
'
navigation/addToScheduledDeletion
'
,
payload
:
'
element
'
},
{
mutation
:
'
notifications/notify
'
,
payload
:
{
type
:
'
success
'
,
text
:
'
Element deletion has been scheduled.
'
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment