Skip to content
Snippets Groups Projects

Handle missing neighbor data when switching to another element

Merged Erwan Rouchet requested to merge header-actions-nullish-neighbors into master

Closes #879 (closed)

It seems this was a rare race condition in which only a portion of an if statement got evaluated before the Vuex store changed, causing the rest of the if to still cause a TypeError. JS is incredibly unreliable. This switches to a null-ish operator, which hopefully should be executed in one go and not broken up by some async code.

Edited by Erwan Rouchet

Merge request reports

Checking pipeline status.

Merged by Bastien AbadieBastien Abadie 3 years ago (Dec 28, 2021 11:33am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading