Skip to content

Restart to page 1 when switching between routes

Erwan Rouchet requested to merge fix-page-number-reset into master

Closes #1049 (closed)

  • Multiple components have been changed to use the vue-router in-component guards when available, which would not be called when switching between different views and therefore avoids the issue.
  • For the components that cannot have in-component guards, the watchers were updated to compare the path attribute of the previous and current route objects, which will change depending on the matched route. This does not include query parameters, so this detects route changes and not parameter changes.
  • The OAuth credentials list and user groups list no longer refer to the $route anywhere, as they are within tabs in the same user profile page; they could collide with each other otherwise.
  • The memberships list, used in multiple pages (corpus edition, repository details, worker details, model details), which all have different designs and behaviors, does not use the route either.

CI is failing due to an test failure that already occurs on master and is not related to this MR.

Merge request reports

Loading