Skip to content

Remove unused configuration name display from WorkerRunWithParents

Erwan Rouchet requested to merge remove-workerrunwithparents-configuration into master

While testing !1393 (merged), I noticed that there was a duplicated API request to ListWorkerConfigurations: one had no parameters, and the second one had ?archived=false. It turns out that the first query was made by WorkerRunWithParents and the second one was the expected one, from Configurations/List.vue. WorkerRunWithParents was fetching the configuration in order to display its name, but was only displaying the name when the show-version-details prop was not set, and was otherwise not using the configuration at all because the Workers/Version/Details.vue component can handle the configuration name.

showVersionDetails had been implemented in !1148 (merged). There had been quite a lot of iterations on the design, and at some point the template details page was using the Details component while the process configuration page was not, causing the addition of a showWorkerDetails prop in https://gitlab.com/teklia/arkindex/frontend/-/commit/144ceae85074a8d09e74c1a512671b6df5153bda?merge_request_iid=1148. This prop was renamed to showVersionDetails in https://gitlab.com/teklia/arkindex/frontend/-/commit/6279cc56a81cd93c29ec7e97efe7415356479c85?merge_request_iid=1148. In the end, showVersionDetails was also enabled on the process configuration page in https://gitlab.com/teklia/arkindex/frontend/-/commit/8120d89f51430944f69c987f172325791963b71b?merge_request_iid=1148, making the prop and the API request useless.

Merge request reports

Loading