Skip to content

Fix Show all models toggle

Erwan Rouchet requested to merge fix-all-models-toggle into master

Closes #1287 (closed), !1549 (closed)

While reviewing !1549 (closed), I tried to look at why the switch was misbehaving, because if it causes that much trouble, we need to figure out if we should try to find alternatives to it and switch the switch. It turns out the implementation with v-on:click made it so both the input or the label and the div would get the event, so they would both cause the input to be toggled, resulting in the strange behavior we observed. I tried to clean some things up because there are some weird CSS classes on this modal and ended up making the field's alignment work with a has-text-right on a parent div instead, which suddenly made the input work normally so all the custom event handling could be removed.

screen-2023-09-12_09.48.19

Edited by Erwan Rouchet

Merge request reports

Loading