Skip to content

Draft: Rework search components

Valentin Rigal requested to merge reactive-search into release-1.7.1

Closes #1519

I seems that Vue watchers handle this better that relying on change events. I noticed a similar error when updating the corpus, sort parameter erased and more. I'm not a fan of the query v-model (most logic is implemented in the view's component which is hard to track). At first I tried not to change everything, but it was becoming over complex and I ended removing many lines.

I saw a computed used as a data (and passed as v-model) and another computed handling this.$router and trigerring search(). It was quite confusing. The API search uses the unique helper but I noticed no duplicate call initially (surprisingly).

Merge request reports