Skip to content
Snippets Groups Projects

Adjust fill-height CSS so that the element details page does not vertically overflow the browser window

Merged ml bonhomme requested to merge elem-details-width into release-1.7.1

closes #1522 (closed)

Yes I wasted time trying to do something else instead of just adjusting this value and surprise surprise it did not work

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ml bonhomme requested review from @erouchet

    requested review from @erouchet

  • changed milestone to %Arkindex 1.7.1

  • This does not actually fix the issue but only hides it in the case where an element's path only occupies one line in the header. We would probably need to restructure the main template of the frontend to handle this properly using multiple flexboxes:

    ┌──────────────────────────────────────┐
    │Navbar                                │◄── App.vue    
    ├──────────────────────────────────────┤
    │┌────────────────────────────────────┐│
    ││Paths                        Actions│◄─── Element.vue
    │├────────────────────────────────────┤│
    ││┌────────┬────────────────┬────────┐││
    │││        │                │        │││
    │││        │   Interactive  │        │││
    │││  Tree  │      Image     │Details │││
    │││        │                │        │││
    │││        │                │        │││
    ││└────────┴────────────────┴────────┘││
    │└────────────────────────────────────┘│
    ├──────────────────────────────────────┤
    │Footer                                │
    └──────────────────────────────────────┘

    This would require checking the layout of every single view to make sure we don't break anything, but it could probably avoid the issues we had that forced us to hardcode some height values like this. This also could allow independent scrolling of the tree or details panels, something which had been discussed multiple times in the past like in this request. So we'll need to revisit that later.

  • Erwan Rouchet added 3 commits

    added 3 commits

    • 84db8065...8e64a851 - 2 commits from branch release-1.7.1
    • ffd90b59 - Adjust fill-height CSS so that the element details page does not vertically...

    Compare with previous version

  • Erwan Rouchet enabled an automatic merge when all merge checks for ffd90b59 pass

    enabled an automatic merge when all merge checks for ffd90b59 pass

Please register or sign in to reply
Loading