Pyproject packaging and last misses on Licensing

.gitlab-ci.yml

@@ -153,10 +153,10 @@ deploy-pypi:
     - tags
 
   before_script:
-    - pip install twine
+    - pip install twine build
 
   script:
-    - python setup.py sdist bdist_wheel
+    - python -m build
     - twine upload -r pypi dist/*
 
 bump-python-deps:
@@ -167,7 +167,7 @@ bump-python-deps:
     - schedules
 
   script:
-    - devops python-deps requirements.txt doc-requirements.txt
+    - devops python-deps pyproject.toml doc-requirements.txt
 
 release-notes:
   stage: deploy

Dockerfile

@@ -9,8 +9,7 @@ WORKDIR /src
 
 # Copy DAN data
 COPY dan dan
-COPY requirements.txt *-requirements.txt setup.py VERSION README.md ./
+COPY pyproject.toml README.md ./
 
-# Install DAN as a package with GitLab package registry
-RUN --mount=type=secret,id=netrc,target=/root/.netrc \
-    pip install . --no-cache-dir
+# Install DAN as a package
+RUN pip install . --no-cache-dir

MANIFEST.in

 include LICENSE
 include LICENCE
-include requirements.txt
-include doc-requirements.txt
-include mlflow-requirements.txt
-include VERSION
 include README.md

Makefile

 .PHONY: release
 
 release:
-	$(eval version:=$(shell cat VERSION))
-	echo $(version)
-	git commit VERSION -m "Version $(version)"
+	# Grep the version from pyproject.toml, squeeze multiple spaces, delete double and single quotes, get 3rd val.
+	# This command tolerates multiple whitespace sequences around the version number.
+	$(eval version:=$(shell grep -m 1 version pyproject.toml | tr -s ' ' | tr -d '"' | tr -d "'" | cut -d' ' -f3))
+	echo Releasing version $(version)
+	git commit pyproject.toml -m "Version $(version)"
 	git tag $(version)
 	git push origin main $(version)

README.md

@@ -4,7 +4,7 @@
 
 For more details about this package, make sure to see the documentation available at <https://atr.pages.teklia.com/dan/>.
 
-This is an open-source project, licensed using [the MIT license](https://opensource.org/license/mit/).
+This is an open-source project, licensed using [the CeCILL-C license](https://cecill.info/index.en.html).
 
 ## Inference
 

VERSION

-0.2.0rc5

doc-requirements.txt

 black==24.3.0
-doc8==1.1.1
 # Pick a specific version because griffe==0.32.0 introduces a bug
 griffe==0.31.0
-mkdocs==1.4.2
 mkdocs-material==9.1.9
-mkdocstrings==0.20.0
 mkdocstrings-python==0.9.0
 recommonmark==0.7.1

docs/get_started/development.md

@@ -77,11 +77,11 @@ This documentation uses [Sphinx](http://www.sphinx-doc.org/) and was generated u
 
 ### Setup
 
-Add the `docs` extra when installing `teklia-dan`:
+Install the needed dependencies through:
 
 ```shell
 # In a clone of the Git repository
-pip install .[docs]
+pip install -r doc-requirements.txt
 ```
 
 Build the documentation using `mkdocs serve -v`. You can then write in [Markdown](https://www.markdownguide.org/) in the relevant `docs/*.md` files, and see live output on http://localhost:8000.

mlflow-requirements.txt

-mlflow-skinny==2.2.2
-pandas==2.0.0

pyproject.toml

+[build-system]
+requires = ["setuptools >= 61.0"]
+build-backend = "setuptools.build_meta"
+
+[project]
+name = "atr-dan"
+version = "0.2.0rc5"
+description = "Teklia DAN"
+readme = "README.md"
+requires-python = ">=3.10"
+authors = [
+    { name = "Teklia", email = "contact@teklia.com" },
+]
+dependencies = [
+    "albumentations==1.3.1",
+    "arkindex-export==0.1.9",
+    "boto3==1.26.124",
+    "flashlight-text==0.0.7",
+    "imageio==2.26.1",
+    "imagesize==1.4.1",
+    "lxml==5.2.0",
+    "matplotlib==3.8.3",
+    "mdutils==1.6.0",
+    "nltk==3.8.1",
+    "numpy==1.24.3",
+    "PyYAML==6.0.1",
+    "scipy==1.12.0",
+    "sentencepiece==0.1.99",
+    "teklia-line-image-extractor==0.2.9",
+    "teklia-nerval==0.3.3-rc1",
+    "tenacity==8.2.3",
+    "tensorboard==2.12.2",
+    "torch==2.2.0",
+    "torchaudio==2.2.0",
+    "torchvision==0.17.0",
+    "tqdm==4.65.0",
+]
+
+keywords = ["python", "HTR", "OCR", "NER", "machine learning", "pytorch"]
+classifiers = [
+    "Development Status :: 4 - Beta",
+    "License :: CeCILL-C Free Software License Agreement (CECILL-C)",
+    # Specify the Python versions you support here.
+    "Programming Language :: Python :: 3 :: Only",
+    "Programming Language :: Python :: 3.10",
+    "Programming Language :: Python :: 3.11",
+    # Topics
+    "Topic :: Software Development :: Libraries :: Python Modules",
+    "Topic :: Text Processing :: Linguistic",
+    "Topic :: Scientific/Engineering :: Artificial Intelligence",
+    "Topic :: Scientific/Engineering :: Image Recognition",
+]
+
+[project.optional-dependencies]
+mlflow = [
+    "mlflow-skinny==2.2.2",
+    "pandas==2.0.0",
+]
+
+[project.scripts]
+teklia-dan = "dan.cli:main"
+
+[project.urls]
+Homepage = "https://atr.pages.teklia/dan/"
+Documentation = "https://atr.pages.teklia/dan/"
+Repository = "https://gitlab.teklia.com/atr/dan"
+"Bug Tracker" = "https://gitlab.teklia.com/atr/dan/issues"
+Maintainers = "https://teklia.com"
+
+[tool.setuptools]
+license-files = ["LICENSE", "LICENCE"]
+
+[tool.setuptools.packages]
+find = {}
+
 [tool.ruff]
 exclude = [".git", "__pycache__"]
 

requirements.txt

-albumentations==1.3.1
-arkindex-export==0.1.9
-boto3==1.26.124
-flashlight-text==0.0.7
-imageio==2.26.1
-imagesize==1.4.1
-lxml==5.2.0
-matplotlib==3.8.3
-mdutils==1.6.0
-nltk==3.8.1
-numpy==1.24.3
-PyYAML==6.0.1
-scipy==1.12.0
-sentencepiece==0.1.99
-teklia-line-image-extractor==0.2.9
-teklia-nerval==0.3.3-rc1
-tenacity==8.2.3
-tensorboard==2.12.2
-torch==2.2.0
-torchaudio==2.2.0
-torchvision==0.17.0
-tqdm==4.65.0

setup.py

-#!/usr/bin/env python
-# Copyright Teklia (contact@teklia.com) & Denis Coquenet
-# This code is licensed under CeCILL-C
-
-# -*- coding: utf-8 -*-
-
-from pathlib import Path
-from typing import List
-
-from setuptools import find_packages, setup
-
-
-def parse_requirements_line(line) -> str:
-    # Special case for git requirements
-    if line.startswith("git+http"):
-        assert "@" in line, "Branch should be specified with suffix (ex: @master)"
-        assert (
-            "#egg=" in line
-        ), "Package name should be specified with suffix (ex: #egg=kraken)"
-        package_name: str = line.split("#egg=")[-1]
-        return f"{package_name} @ {line}"
-    # Special case for submodule requirements
-    elif line.startswith("-e"):
-        package_path: str = line.split(" ")[-1]
-        package = Path(package_path).resolve()
-        return f"{package.name} @ file://{package}"
-    else:
-        return line
-
-
-def parse_requirements(filename: str) -> List[str]:
-    path = Path(__file__).parent.resolve() / filename
-    assert path.exists(), f"Missing requirements: {path}"
-    return list(
-        map(parse_requirements_line, map(str.strip, path.read_text().splitlines()))
-    )
-
-
-setup(
-    name="atr-dan",
-    version=Path("VERSION").read_text(),
-    description="Teklia DAN",
-    long_description=Path("README.md").read_text(),
-    long_description_content_type="text/markdown",
-    author="Teklia",
-    author_email="contact@teklia.com",
-    url="https://gitlab.teklia.com/atr/dan",
-    python_requires=">=3.10",
-    install_requires=parse_requirements("requirements.txt"),
-    packages=find_packages(),
-    entry_points={
-        "console_scripts": [
-            "teklia-dan=dan.cli:main",
-        ]
-    },
-    extras_require={
-        "docs": parse_requirements("doc-requirements.txt"),
-        "mlflow": parse_requirements("mlflow-requirements.txt"),
-    },
-    license="CeCILL-C",
-    license_files=(
-        "LICENSE",
-        "LICENCE",
-    ),
-)

tox.ini

@@ -10,13 +10,17 @@ wheel_build_env = .pkg
 deps =
     pytest>=6
     pytest-responses
-    -rrequirements.txt
 commands =
     pytest {tty:--color=yes} {posargs}
 
 [testenv:doc]
 extras = docs
 
+# No need to install dan in this env
+skip_install = True
+
+deps = -rdoc-requirements.txt
+
 commands =
   mkdocs build --clean --verbose --strict