Skip to content
Snippets Groups Projects

Do not load dataset information at instanciation

Merged Yoann Schneider requested to merge fix-image-downloader into main

Allows to instantiate an ImageDownloader outside the teklia-dan datasets download command.

To reproduce the previous issue

> from dan.datasets.download.images import ImageDownloader
> from pathlib import Path
> im = ImageDownloader(output=Path("/tmp"))
  File "/usr/local/lib/python3.10/dist-packages/dan/datasets/download/images.py", line 76, in __init__
    split_data["text"] for split_data in self.split[TRAIN_NAME].values()
KeyError: 'train'

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Manon BlancoManon Blanco 7 months ago (Sep 3, 2024 6:53am UTC)

Merge details

  • Changes merged into main with fb4c15d8 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading