Do not create an Arkindex client on import

assigned to @mblanco

Up: this lib is used in base-worker and automatically set a DEFAULT_CLIENT. But some workers haven't access to Internet (offline/GPU workers on JeanZay). So these workers cannot be used anymore: https://ee.preprod.arkindex.teklia.com/process/03fb5096-7f0b-4e85-a3f7-18f0befbe307/0.

We should have something like:

from arkindex import ArkindexClient as BaseArkindexClient

class ArkindexClient(BaseArkindexClient):
	def __init__(*args, **kwargs) -> None:
		# Skip SSL verification in Arkindex API client for local development hosts
		verify = should_verify_cert(options.get("base_url"))
		if not verify:
			urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
			logger.warn("SSL certificate verification is disabled for Arkindex API calls")
		super().init(verify=verify, *args, **kwargs)

	@retry(
		retry=retry_if_exception(_is_500_error),
		wait=wait_exponential(multiplier=2, min=3),
		reraise=True,
		stop=stop_after_attempt(5),
		before_sleep=before_sleep_log(logger, logging.INFO),
	)
	def request(*args, **kwargs):
		"""
		Proxy all Arkindex API requests with a retry mechanism
		in case of 50X errors
		The same API call will be retried 5 times, with an exponential sleep time
		going through 3, 4, 8 and 16 seconds of wait between call.
		If the 5th call still gives a 50x, the exception is re-raised
		and the caller should catch it
		Log messages are displayed before sleeping (when at least one exception occurred)
		"""
		return self.request(*args, **kwargs)

And the DEFAULT_CLIENT shoud be defined in your code, not in this lib.

assigned to @mblanco

Let's go with your suggestion

marked this issue as related to arkindex/api-client#38 (closed)

As discussed in Slack, we will be moving retried_request to the API client so that the toolbox does not need to create its own client and works offline. This will remove the _get_arkindex_client method and leave that responsibility up to downstream projects, so no more kwargs either.

changed title from Support login arguments to Arkindex client to Do not create an Arkindex client on import

mentioned in merge request !16 (merged)

closed with merge request !16 (merged)

Do not create an Arkindex client on import

Designs

Child items ...

Activity