Skip to content
Snippets Groups Projects
Commit a2f8c49b authored by Eva Bardou's avatar Eva Bardou :frog:
Browse files

Log a message when everything went well as well

parent d5ad952d
No related branches found
No related tags found
1 merge request!504Log a message when everything went well as well
Pipeline #162398 passed
......@@ -230,12 +230,15 @@ class ElementsWorker(
with contextlib.suppress(Exception):
self.update_activity(element.id, ActivityState.Error)
message = (
f"Ran on {count} elements: {count - failed} completed, {failed} failed"
)
if failed:
logger.error(
f"Ran on {count} elements: {count - failed} completed, {failed} failed"
)
logger.error(message)
if failed >= count: # Everything failed!
sys.exit(1)
else:
logger.info(message)
def process_element(self, element: Element | CachedElement):
"""
......@@ -505,9 +508,12 @@ class DatasetWorker(BaseWorker, DatasetMixin, TaskMixin):
if dataset_artifact:
dataset_artifact.unlink(missing_ok=True)
message = (
f"Ran on {count} datasets: {count - failed} completed, {failed} failed"
)
if failed:
logger.error(
f"Ran on {count} datasets: {count - failed} completed, {failed} failed"
)
logger.error(message)
if failed >= count: # Everything failed!
sys.exit(1)
else:
logger.info(message)
......@@ -792,7 +792,9 @@ def test_run(
assert [(level, message) for _, level, message in caplog.record_tuples] == [
(logging.INFO, "Loaded Worker Fake worker @ 123412 from API"),
(logging.INFO, "Processing Dataset (dataset_id) (1/1)"),
] + extra_logs
*extra_logs,
(logging.INFO, "Ran on 1 datasets: 1 completed, 0 failed"),
]
@pytest.mark.parametrize(
......@@ -890,4 +892,6 @@ def test_run_read_only(
assert [(level, message) for _, level, message in caplog.record_tuples] == [
(logging.WARNING, "Running without any extra configuration"),
(logging.INFO, "Processing Dataset (dataset_id) (1/1)"),
] + extra_logs
*extra_logs,
(logging.INFO, "Ran on 1 datasets: 1 completed, 0 failed"),
]
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment