Fix some review related code snippets

arkindex_worker/worker.py

@@ -30,7 +30,8 @@ class BaseWorker(object):
             self.work_dir = os.path.join(xdg_data_home, "arkindex")
             os.makedirs(self.work_dir, exist_ok=True)
 
-        if not os.environ.get("WORKER_VERSION_ID"):
+        self.worker_version_id = os.environ.get("WORKER_VERSION_ID")
+        if not self.worker_version_id:
             raise Exception(
                 "Missing WORKER_VERSION_ID environment variable to start the Worker"
             )
@@ -197,7 +198,7 @@ class ElementsWorker(BaseWorker):
                 "corpus": element.corpus.id,
                 "polygon": polygon,
                 "parent": element.id,
-                "worker_version": os.environ.get("WORKER_VERSION_ID"),
+                "worker_version": self.worker_version_id,
             },
         )
         self.report.add_element(element.id, type)

tests/test_base_worker.py

@@ -14,6 +14,7 @@ def test_init_default_local_share():
     worker = BaseWorker()
 
     assert worker.work_dir == os.path.expanduser("~/.local/share/arkindex")
+    assert worker.worker_version_id == "12341234-1234-1234-1234-123412341234"
 
 
 def test_init_default_xdg_data_home(monkeypatch):
@@ -22,6 +23,7 @@ def test_init_default_xdg_data_home(monkeypatch):
     worker = BaseWorker()
 
     assert worker.work_dir == f"{path}/arkindex"
+    assert worker.worker_version_id == "12341234-1234-1234-1234-123412341234"
 
 
 def test_init_var_ponos_data_given(monkeypatch):
@@ -30,6 +32,7 @@ def test_init_var_ponos_data_given(monkeypatch):
     worker = BaseWorker()
 
     assert worker.work_dir == f"{path}/current"
+    assert worker.worker_version_id == "12341234-1234-1234-1234-123412341234"
 
 
 def test_init_var_worker_version_id_missing(monkeypatch):