Skip to content
Snippets Groups Projects

Use the serializer context to get an element's corpus

Merged Erwan Rouchet requested to merge corpus-context into master
All threads resolved!

Requires !1305 (merged), Closes #700 (closed)

This removes some remnants of the old ListElements in which filtering by corpus was only optional, and uses the fact that all elements in ListElement{s,Children,Parents} are now of the same corpus to use the serializer context to send the corpus instead of retrieving the same corpus dozens of times in an SQL JOIN.

This removes an entire Hash Join on all the retrieved elements before the LIMIT is applied, shaving off 15% of the endpoint execution time on GoLFor (a corpus with 4 million elements on my local DB).

Edited by Erwan Rouchet

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Bastien AbadieBastien Abadie 4 years ago (Apr 16, 2021 2:56pm UTC)

Merge details

  • Changes merged into master with 244b7ac3 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Erwan Rouchet added 4 commits

    added 4 commits

    • 81233b5d - Add an assertExactQueries on ListElements
    • 01094851 - Release the Kraken
    • d7899283 - Use the serializer context to get an element's corpus
    • 8395cf80 - Update for assertExactQueries

    Compare with previous version

  • Erwan Rouchet changed the description

    changed the description

  • Erwan Rouchet resolved all threads

    resolved all threads

  • Erwan Rouchet mentioned in merge request !1306 (merged)

    mentioned in merge request !1306 (merged)

  • Erwan Rouchet added 7 commits

    added 7 commits

    Compare with previous version

  • Erwan Rouchet resolved all threads

    resolved all threads

  • Erwan Rouchet added 6 commits

    added 6 commits

    Compare with previous version

  • Bastien Abadie resolved all threads

    resolved all threads

  • Bastien Abadie added 4 commits

    added 4 commits

    Compare with previous version

  • Bastien Abadie resolved all threads

    resolved all threads

  • Bastien Abadie added 6 commits

    added 6 commits

    Compare with previous version

  • Erwan Rouchet resolved all threads

    resolved all threads

  • Erwan Rouchet added 16 commits

    added 16 commits

    Compare with previous version

  • Bastien Abadie mentioned in commit 244b7ac3

    mentioned in commit 244b7ac3

  • Please register or sign in to reply
    Loading