Skip to content
Snippets Groups Projects

Fix lots of potential stale reads in Element.add_parent and .remove_child

Merged Fix lots of potential stale reads in Element.add_parent and .remove_child
element-path-stale-reads into master
All threads resolved!
Merged Erwan Rouchet requested to merge element-path-stale-reads into master
All threads resolved!

Part 1/2 of #881 (closed), resolves ARKINDEX-BACKEND-SD

This fixes six possible stale reads in both add_parent and remove_child, so this affects at least CreateElement, CreateElementParent, DestroyElementParent and the move_element RQ task. There still are more elsewhere :D

See https://gitlab.com/arkindex/backend/-/issues/881#note_714675726 for details

Edited by Erwan Rouchet

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Bastien AbadieBastien Abadie 3 years ago (Nov 2, 2021 3:42pm UTC)

Merge details

  • Changes merged into master with 4f364cd8 (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bastien Abadie resolved all threads

    resolved all threads

  • Bastien Abadie resolved all threads

    resolved all threads

  • Bastien Abadie added 5 commits

    added 5 commits

    • 1dc9477d...f76a2f5f - 4 commits from branch master
    • 516ef7f7 - Fix lots of potential stale reads in Element.add_parent and .remove_child

    Compare with previous version

  • Bastien Abadie enabled an automatic merge when the pipeline for 516ef7f7 succeeds

    enabled an automatic merge when the pipeline for 516ef7f7 succeeds

  • Bastien Abadie mentioned in commit 4f364cd8

    mentioned in commit 4f364cd8

  • Bastien Abadie merged

    merged

  • Erwan Rouchet mentioned in issue #802 (closed)

    mentioned in issue #802 (closed)

    • Please register or sign in to reply