Add archived configurations toggle
Closes #1027 (closed)
- I tried using a toggle to toggle between enabled and archived configurations, like the toggles in the Display menu in elements, but I could not get it to align properly with the list, so I used tabs instead.
- Added a new icon for the archive button. I don't really like it, but it was the least worst available!
- The error message notification has been moved from the
<menu>
, where it would be really small and leave a big empty space on the right, to the right, replacing the default "Select a configuration" notification when it appears. - The configuration list and the save button now display a loading spinner while they are loading.
- The frontend cannot check for the user's rights on the worker or repository easily, so there are no checks there and the user will get an error notification when trying to archive when they only have Guest rights.
Merge request reports
Activity
requested review from @babadie
added 5 commits
-
480a5da5...c577e9d1 - 2 commits from branch
master
- 41dc21ed - Add support for archived configurations
- 81a96080 - Fix handling of archived updates
- c21a4077 - Update tests
Toggle commit list-
480a5da5...c577e9d1 - 2 commits from branch
- Resolved by Erwan Rouchet
Congratulations for opening the Can of Worms of Modal Buttons!
You could click on the wrong button here, both by misclick and by habit because we have modal dialogs that use buttons on the right to mean the main action of the modal:
… But we also already have the complete opposite:
You could mistake both sides, because we have other modals where the buttons are opposite (and the good button is on the right):
You could also take this as a Cancel / Close button rather than something that actually does something.
Alternatively, we could put the archive button on the configuration itself, so that it relates to the configuration and not to the configuration selection modal:
Or if a button overlapping a
<pre>
isn't fine for you, we can repeat the title of the configuration like we do in most displays to get some extra space:We can also change the color of the button so that it becomes a bit less visible than the modal's actual actions, the most important buttons. Should the Unarchive button be in another color? Should it even be called Unarchive if we have a Enabled tab — should it be Enable?
Edited by Ghost User
added 6 commits
-
c21a4077...a2b1dcc5 - 2 commits from branch
master
- 7d55e37f - Add support for archived configurations
- 829d756a - Fix handling of archived updates
- 8a2f7b2d - Update tests
- 1c549f5a - Use a button in the bottom left corner
Toggle commit list-
c21a4077...a2b1dcc5 - 2 commits from branch
added 6 commits
-
1c549f5a...067a3800 - 2 commits from branch
master
- 7b9c6416 - Add support for archived configurations
- 8a0d369c - Fix handling of archived updates
- 618d7711 - Update tests
- f7ed20f4 - Use a button in the bottom left corner
Toggle commit list-
1c549f5a...067a3800 - 2 commits from branch
enabled an automatic merge when the pipeline for f7ed20f4 succeeds
mentioned in commit 2de0b669