Upgrade to Bulma v1
Refs. https://redmine.teklia.com/issues/7464
Based on previous work !1705 (closed).
Merge request reports
Activity
assigned to @vrigal
Resolved by Valentin RigalStill in progress, but it seems to be going fine for now. I initially rebased most important commits onto 1.7.3, then 1.8.0 (Vite+husky). There is 1 warning left during compilation:
-
npm warn deprecated lodash.get@4.4.2: This package is deprecated. Use the optional chaining (?.) operator instead.And something like 7 runtime warnings (most seems related to HTML rules and should be easy to patch). I still have to add the "Lumen" theme.
-
- Last reply by Bastien Abadie
added 13 commits
-
2bf3180b...5d780b3c - 2 commits from branch
release-1.8.0 - 3611a1da - 1 earlier commit
- 7741545a - Update to bulma v1
- 6c265ad3 - Remove bulma-switch and bulma-tooltip
- 3b1ed728 - Rebase and bump Bulma packages
- b6737c6a - Update existing SCSS
- 55535689 - Run formatter
- a713674e - Fix imports
- b0bcdaac - Fix runtime warnings
- 56fec177 - Suggestion
- 5b2aec22 - Add Lumen theme
- 2f95a384 - Major Lumen theme fixes
Toggle commit list-
2bf3180b...5d780b3c - 2 commits from branch
added 2 commits
added 15 commits
-
4edc5df2 - 1 commit from branch
release-1.8.0 - 4edc5df2...6bd9b105 - 4 earlier commits
- 85e119c3 - Update existing SCSS
- 79adda54 - Run formatter
- d963be1f - Fix imports
- 377e8771 - Fix runtime warnings
- 70c6eed3 - Suggestion
- c8a90e9f - Add Lumen theme
- 1ad73203 - Major Lumen theme fixes
- 7a48ecd9 - Fix multiprogress bar
- 9adb5db6 - Fix components
- 04b22b4a - Replace is-marginless by m-0
Toggle commit list-
4edc5df2 - 1 commit from branch
changed milestone to %Arkindex 1.8.0
requested review from @babadie
- Resolved by Valentin Rigal
That was quite much work to get it look like the actual Arkindex.
I did not implement dark theme (which is usable but quite ugly and has some unreadeable black on entities or modal body).
This removes bulma-tooltip and bulma-switch. The code is still hosted at https://www.npmjs.com/package/bulma-switch?activeTab=code, but unfortunately it is compiled with Gulp. I suppose it will be quite hard to port this code to Dart. Switches are actually rendered as check boxes.
- Last reply by Erwan Rouchet
- Resolved by Valentin Rigal
Pretty amazing... I have a hard time finding meaningful differences.
I think we should consider dropping bulma-switch, using default HTML elements is not a bad idea.
Regarding the tooltip, I don't even know where they are used. Thoughts @erouchet ?
- Last reply by Bastien Abadie
LGTM, I'll let @erouchet review, considering we drop switches & will replace tooltips in a followup.
- Resolved by Valentin Rigal
The FilterBar's suggestions no longer have a background or border
- Resolved by Valentin Rigal
All of the switches probably need to be restructured as regular Bulma checkboxes, because the checkboxes are not styled at all by Bulma:
My favorite:
- Resolved by Valentin Rigal
The user dropdown now has white text on a white background:
- Resolved by Valentin Rigal
There are unexpected scrollbars on the S3 import page
- Resolved by Valentin Rigal
The
border-radiusof most elements has increased, and there are shadows on most buttons which Lumen was removing. Those are not a huge issue, but they do make the frontend feel different overall, since they affect many elements on most pages. - Last reply by Valentin Rigal
mentioned in issue #1551 (closed)
added 2 commits
added 26 commits
-
84d6d8f8...69f3fcf0 - 8 commits from branch
release-1.8.0 - 69f3fcf0...2f1ef9a2 - 8 earlier commits
- ecd6b05a - Suggestion
- f5ebdcd2 - Add Lumen theme
- 13a303e4 - Major Lumen theme fixes
- 6bf63496 - Fix multiprogress bar
- 5f616e0a - Fix components
- 0e5ace31 - Replace is-marginless by m-0
- 82909d0e - Update all samp attributes
- 928f7229 - Serve light theme only
- 93902780 - Suggestions
- 1272bfde - Update all switches to checkboxes
Toggle commit list-
84d6d8f8...69f3fcf0 - 8 commits from branch
added 2 commits
requested review from @erouchet
I'm testing all pages by comparison, the main "issue" (more like a nit to be honest), is a slight margin/padding change on some select.
For example, in the metadata free edit component, the type select is sliiiightly bigger than in 1.7.3 and is visible because the text input next to it has the "correct" size
The actions in a process task top bar have a bit more margin
Edited by Bastien Abadieadded 1 commit
- 21d3dc1e - Fix a weird bug where bottom border is hidden depending on screen resolution
added 1 commit
- a57251d1 - Ensure every item renders at the right height on a control div
mentioned in issue #1438 (closed)
mentioned in issue #1560 (closed)
