.arkindex.yml

@@ -4,7 +4,7 @@ version: 2
 workers:
   - slug: thumbnails-generator
     name: Thumbnails Generator
-    type: generator
+    type: Utils
     docker:
       build: Dockerfile
     configuration:

.gitlab-ci.yml

@@ -134,3 +134,4 @@ publish-worker:
         - demo
         # Publish worker on https://arkindex.teklia.com
         - prod
+        - elephant

pyproject.toml

@@ -4,6 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "worker_thumbnails_generator"
+license = { file = "LICENSE" }
 version = "0.1.0"
 description = "Worker to generate thumbnails for Arkindex elements"
 dynamic = ["dependencies"]

tests/test_worker.py

@@ -175,6 +175,13 @@ def test_process_element_no_images_found(caplog, mock_worker):
         folder=False,
         response=[],
     )
+    mock_worker.api_client.add_response(
+        "ListElementChildren",
+        id=folder.id,
+        folder=False,
+        recursive=True,
+        response=[],
+    )
 
     mock_worker.process_element(folder)
 

worker_thumbnails_generator/worker.py

@@ -31,15 +31,13 @@ class ThumbnailsGenerator(ElementsWorker):
         """
         List all elements in a folder that could have images and could be used as thumbnails.
         """
-        # First try with the first page of results returned by a non-recursive list, much faster than recursive
-        results = self.list_element_children(folder, folder=False)
-        yield from results
+        # First try with a non-recursive list, much faster than recursive
+        yield from self.list_element_children(folder, folder=False)
 
         # Fallback to going through all of the non-folder elements recursively.
-        # If there were no results at all, we do not even try to make the other query,
-        # since we already know there will be no results on this one too.
-        if results:
-            yield from self.list_element_children(folder, folder=False, recursive=True)
+        # This request may return some elements even though the previous one did not,
+        # since this folder might only contain folder elements that have non-folder elements.
+        yield from self.list_element_children(folder, folder=False, recursive=True)
 
     def get_first_images(self, folder):
         """
@@ -129,7 +127,7 @@ class ThumbnailsGenerator(ElementsWorker):
 
 def main() -> None:
     ThumbnailsGenerator(
-        description="Worker to generate thumbnails for Arkindex elements"
+        description="Worker to generate thumbnails for Arkindex elements: Utility process"
     ).run()