Skip to content
Snippets Groups Projects
Verified Commit afbe821f authored by Yoann Schneider's avatar Yoann Schneider :tennis:
Browse files

Higher level on retry logs

parent 16079372
No related branches found
No related tags found
1 merge request!318Higher level on retry logs
...@@ -33,7 +33,7 @@ TRIM_RETURN_REGEX = re.compile(r"[\r\n]+") ...@@ -33,7 +33,7 @@ TRIM_RETURN_REGEX = re.compile(r"[\r\n]+")
def _retry_log(retry_state, *args, **kwargs): def _retry_log(retry_state, *args, **kwargs):
logger.debug( logger.warning(
f"Request to {retry_state.args[0]} failed ({repr(retry_state.outcome.exception())}), " f"Request to {retry_state.args[0]} failed ({repr(retry_state.outcome.exception())}), "
f"retrying in {retry_state.idle_for} seconds" f"retrying in {retry_state.idle_for} seconds"
) )
......
...@@ -741,7 +741,7 @@ def test_download_image_error(iiif_url, caplog, capsys): ...@@ -741,7 +741,7 @@ def test_download_image_error(iiif_url, caplog, capsys):
assert captured.out == "deadbeef: Image URL must be HTTP(S)\n" assert captured.out == "deadbeef: Image URL must be HTTP(S)\n"
def test_download_image_error_try_max(responses): def test_download_image_error_try_max(responses, caplog):
# An image's URL # An image's URL
url = ( url = (
"https://blabla.com/iiif/2/image_path.jpg/231,699,2789,3659/full/0/default.jpg" "https://blabla.com/iiif/2/image_path.jpg/231,699,2789,3659/full/0/default.jpg"
...@@ -774,6 +774,12 @@ def test_download_image_error_try_max(responses): ...@@ -774,6 +774,12 @@ def test_download_image_error_try_max(responses):
fixed_url fixed_url
] ]
# Check error log
assert len(caplog.record_tuples) == 2
# We should only have WARNING levels
assert set(level for _, level, _ in caplog.record_tuples) == {logging.WARNING}
@pytest.mark.parametrize("allow_empty", (True, False)) @pytest.mark.parametrize("allow_empty", (True, False))
def test_empty_transcription(allow_empty, mock_database): def test_empty_transcription(allow_empty, mock_database):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment