Skip to content
Snippets Groups Projects

Implement format command

Merged Yoann Schneider requested to merge implement-format-command into main

Closes #4 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Solene Tarride
  • There are some errors in the code - I suggested some changes to fix them.

    Here are the commands I used to test your code:

    (dan) set_prod
    (dan) teklia-dan dataset extract --parent 4257bb95-7658-4b27-8840-2b8369b0e4af --element-type page --output dataset_test
    (dan) teklia-dan dataset format --dataset dataset_test/ --image-format .jpg
  • added 1 commit

    • 261e2d63 - Apply 6 suggestion(s) to 1 file(s)

    Compare with previous version

  • Yoann Schneider added 16 commits

    added 16 commits

    • 22353a0a - refactoring + packaging
    • 6bb96aac - remove obsolete code
    • e42d071d - remove not needed files, reorganize inside dan module
    • 99285091 - remove Datasets folder
    • 0afccab8 - implement extraction
    • f48001aa - fix lint
    • a6a94a5c - update defaults in doc
    • 4d0b43a0 - use the right starting tokens
    • 4af68829 - fix tokens retrieval
    • f37ae1f0 - final touches
    • 46f4c299 - add tests, new params
    • dbc99d48 - fix tests, CI, regroupe parser related code in __init__ files
    • 140a8258 - refactor formatters
    • 5d4cc1b3 - store tokens somewhere while they're still needed somehow
    • 234f35c9 - Merge branch 'implement-format-command' of gitlab.com:teklia/atr/dan into implement-format-command
    • 841ba1af - update charset mentios

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Yoann Schneider marked this merge request as ready

    marked this merge request as ready

  • Yoann Schneider resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading