Skip to content
Snippets Groups Projects
Commit e5b1f250 authored by Eva Bardou's avatar Eva Bardou
Browse files

Fix a review related code snippet

parent 6890ca2a
No related branches found
No related tags found
1 merge request!93Retrieve ARKINDEX_CORPUS_ID in create_entity when corpus is None
Pipeline #78482 passed
This commit is part of merge request !93. Comments created here will be created in the context of that merge request.
......@@ -18,7 +18,9 @@ class EntityType(Enum):
class EntityMixin(object):
def create_entity(self, element, name, type, corpus, metas=None, validated=None):
def create_entity(
self, element, name, type, corpus=None, metas=None, validated=None
):
"""
Create an entity on the given corpus through API
Return the ID of the created entity
......
......@@ -90,14 +90,13 @@ def test_create_entity_wrong_type(mock_elements_worker):
def test_create_entity_wrong_corpus(monkeypatch, mock_elements_worker):
elt = Element({"id": "12341234-1234-1234-1234-123412341234"})
# Triggering an error on metas param, giving corpus=None should work since
# Triggering an error on metas param, not giving corpus should work since
# ARKINDEX_CORPUS_ID environment variable is set on mock_elements_worker
with pytest.raises(AssertionError) as e:
mock_elements_worker.create_entity(
element=elt,
name="Bob Bob",
type=EntityType.Person,
corpus=None,
metas="wrong metas",
)
assert str(e.value) == "metas should be of type dict"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment